Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce application model in configuration #152888

Closed
4 tasks done
sandy081 opened this issue Jun 22, 2022 · 0 comments · Fixed by #155212
Closed
4 tasks done

Introduce application model in configuration #152888

sandy081 opened this issue Jun 22, 2022 · 0 comments · Fixed by #155212
Assignees
@rzhao271 @sandy081
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues user-profiles User profile management
Milestone
July 2022

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 22, 2022 •
edited by rzhao271
Loading

In a non default profile window, configuration needs application model layer from which application scoped settings can be read/write.

  • Introduce application configuration model layer
  • Make sure application configuration is active and used only in non default profiles
  • read/write application scoped settings only from application layer and not from user layer
  • Show application tab in settings editor for non default profiles
@sandy081 sandy081 added feature-request Request for new features or functionality config VS Code configuration, set up issues user-profiles User profile management labels Jun 22, 2022
@sandy081 sandy081 added this to the June 2022 milestone Jun 22, 2022
@sandy081 sandy081 self-assigned this Jun 22, 2022
@sandy081 sandy081 mentioned this issue Jun 22, 2022
Merged
@sandy081 sandy081 modified the milestones: June 2022, July 2022 Jun 27, 2022
@kieferrm kieferrm mentioned this issue Jul 9, 2022
Closed
98 tasks
@rzhao271 rzhao271 added the settings-editor VS Code settings editor issues label Jul 14, 2022
@rzhao271 rzhao271 mentioned this issue Jul 14, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 20, 2022
rzhao271 added a commit that referenced this issue Jul 21, 2022
@rzhao271
Fix commands for non-default profiles
8ee4848 
Ref #152888
This was referenced Jul 21, 2022
Merged
Closed
rzhao271 added a commit that referenced this issue Jul 21, 2022
@rzhao271
Fix JSON Settings editor commands wrt Setting profiles (#155884)
f74d2c0 
Ref #152888
@rzhao271 rzhao271 mentioned this issue Jul 21, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

@sandy081 sandy081

Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues user-profiles User profile management
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Add Settings indicator for application-scoped settings microsoft/vscode
3 participants
@rzhao271 @sandy081 @VSCodeTriageBot