Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't fold the menu bar into a hamburger menu when the command center is enabled #152906

Closed
dbaeumer opened this issue Jun 22, 2022 · 13 comments · Fixed by #155223
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug command-center insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Jun 22, 2022

This actually forces me to navigate one level more when I want to get to a menu entry. I think that this is not necessary even not when running in the Web. Could we at least make this an options please.

capture

@dbaeumer
Copy link
Member Author

The hambuger menu made me disable the command center again.

@sbatten sbatten added the under-discussion Issue is under discussion for relevance, priority, approach label Jun 22, 2022
@jrieken jrieken added titlebar VS Code main title bar issues command-center labels Jun 23, 2022
@jrieken
Copy link
Member

jrieken commented Jun 23, 2022

The colour of the burger doesn't look heathy either... @sbatten Can we make it dynamic? Show the menu when there is space and but use the burger when there isn't any?

@sbatten
Copy link
Member

sbatten commented Jun 23, 2022

do you mean that we would not do our normal collapsing (one-by-one) and instead immediately collapse all?

@sbatten
Copy link
Member

sbatten commented Jun 23, 2022

pushed a fix for the color issue

@jrieken
Copy link
Member

jrieken commented Jun 24, 2022

do you mean that we would not do our normal collapsing (one-by-one) and instead immediately collapse all?

Both 🤓 Do the normal collapse until a certain threshold is reached (3?) and then collapse into the burger menu

@heartacker
Copy link
Contributor

heartacker commented Jun 25, 2022

  1. show them if space is enough.
  2. reduce the length of command center while title length reducing IF no enough space for both,until the command center length IS reaching LIMIT_MIN_LENGTH
  3. LAST,collapse the last menu item(s) to the

@jrieken jrieken added this to the July 2022 milestone Jul 1, 2022
@heartacker
Copy link
Contributor

  1. show them if space is enough.
  2. reduce the length of command center while title length reducing IF no enough space for both,until the command center length IS reaching LIMIT_MIN_LENGTH
  3. LAST,collapse the least menu item(s) to the

by the way , Command center should be centered, agree. we could reduce the length of CC for being centered

@NULL0B
Copy link

NULL0B commented Jul 7, 2022

I aggre with this issue, I dont like having an extra level for the menus, but also a ton of free space between left and command center, but I also like the command center as new uniformity in microsoft apps

@sapphyrus
Copy link

The hambuger menu made me disable the command center again.

This change makes me want to turn it off too, but I've unfortunately grown pretty accustomed to the command center. So I guess the only option I have left is to downgrade my vscode version...

@JustinGrote
Copy link
Contributor

As a side note, it has frustrated me enough to work harder on memorizing my keyboard shortcuts, so that's a sneaky benefit I guess? :)

@jimrandell

This comment was marked as spam.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 14, 2022
@JustinGrote
Copy link
Contributor

@sbatten thank you very much!

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 15, 2022
@heartacker
Copy link
Contributor

SEEM THAT there is little bug after click CC and exit
CC

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jul 25, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug command-center insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants