Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "not in" context key expression #154582

Closed
roblourens opened this issue Jul 9, 2022 · 0 comments · Fixed by #155261
Closed

Support "not in" context key expression #154582

roblourens opened this issue Jul 9, 2022 · 0 comments · Fixed by #155261
Assignees
@roblourens @alexdima
Labels
context-keys feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
July 2022

Comments

@roblourens
Copy link
Member

roblourens commented Jul 9, 2022 •
edited
Loading

We have this in keyword: https://code.visualstudio.com/api/references/when-clause-contexts#in-conditional-operator

It seems impossible to do not in. I need this for microsoft/vscode-jupyter#10595 (continuation of microsoft/vscode-jupyter#10595 and #147732 (comment)). Basically I will have a context key with a list of documents where run-by-line is active, and the run-by-line button will be made to appear when the current document is not in that list (in other words, when RBL is not already active)

This looks easy to hook up, I could take it. We have ContextKeyNotInExpr already. I suggest a X not in Y syntax.
@roblourens roblourens mentioned this issue Jul 9, 2022
Closed
@roblourens roblourens added this to the July 2022 milestone Jul 15, 2022
@roblourens roblourens added feature-request Request for new features or functionality context-keys labels Jul 15, 2022
roblourens added a commit that referenced this issue Jul 15, 2022
@roblourens
Support "not in" context key expression
64b0437 
Fixes #154582
@roblourens roblourens mentioned this issue Jul 15, 2022
Merged
roblourens added a commit that referenced this issue Jul 18, 2022
@roblourens
Support "not in" context key expression (#155261)
5acd950 
* Support "not in" context key expression
Fixes #154582

* Tweak var name
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2022
@roblourens roblourens mentioned this issue Jul 21, 2022
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@alexdima alexdima

Labels
context-keys feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Support "not in" context key expression microsoft/vscode
3 participants
@roblourens @alexdima @VSCodeTriageBot