Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OSC 8 hyperlink support #155445

Closed
Tyriar opened this issue Jul 17, 2022 · 2 comments
Closed

Support OSC 8 hyperlink support #155445

Tyriar opened this issue Jul 17, 2022 · 2 comments
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal-links upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2022 •
edited
Loading

Running the following in bash/zsh should give special links with dashed underlines:

printf '\e]8;id=abc;http://example.com/\e\\This is a link中国\e]8;;\e\\\n'

Upstream issue: xtermjs/xterm.js#1134
WIP: xtermjs/xterm.js#3904
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream terminal-links labels Jul 17, 2022
@Tyriar Tyriar added this to the Backlog milestone Jul 17, 2022
@Tyriar Tyriar self-assigned this Jul 17, 2022
@ssbarnea
Copy link

Errata, correct PR is xtermjs/xterm.js#4005

@Tyriar Tyriar modified the milestones: Backlog, September 2022 Aug 30, 2022
Tyriar added a commit to Tyriar/supports-hyperlinks that referenced this issue Aug 30, 2022
@Tyriar
Add vscode which will support hyperlinks in v1.72
40f445b 
See xtermjs/xterm.js#1134 and microsoft/vscode#155445
@Tyriar Tyriar mentioned this issue Aug 30, 2022
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Aug 30, 2022

Oh this already existed: #39278

@Tyriar Tyriar closed this as completed Aug 30, 2022
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 30, 2022
sindresorhus pushed a commit to jamestalmage/supports-hyperlinks that referenced this issue Sep 6, 2022
@Tyriar
Add VSCode support (#17)
45ff1a8 
See xtermjs/xterm.js#1134 and microsoft/vscode#155445
@Tyriar Tyriar removed this from the September 2022 milestone Sep 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality terminal-links upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssbarnea @Tyriar