Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] skip line number change test when restoring state #159032

Closed
aeschli opened this issue Aug 24, 2022 · 2 comments · Fixed by #161768
Closed

[folding] skip line number change test when restoring state #159032

aeschli opened this issue Aug 24, 2022 · 2 comments · Fixed by #161768
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Milestone
September 2022

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 24, 2022

Originally posted by @PieterBranderhorst in #155302 (comment)

I see that you re-added a test I had removed. In folding.ts, in restoreViewState, the test for "state.lineCount !== model.getLineCount()". I suggest removing that test again. I removed it because the new checksum tests detect changes with much greater accuracy and I know that some users use folding with log files. situation and it seems good to keep it.
@aeschli aeschli added this to the September 2022 milestone Aug 24, 2022
@aeschli aeschli self-assigned this Aug 24, 2022
@aeschli aeschli added editor-folding Editor code folding issues bug Issue identified by VS Code Team member as probable bug labels Aug 24, 2022
@aeschli aeschli mentioned this issue Aug 24, 2022
Merged
aeschli added a commit that referenced this issue Sep 26, 2022
@aeschli
[folding] skip line number change test when restoring state #159032
157c446
@aeschli aeschli mentioned this issue Sep 26, 2022
Merged
aeschli added a commit that referenced this issue Sep 26, 2022
@aeschli
[folding] skip line number change test when restoring state #159032 (#…
afdf3fd 
…161768)
@rzhao271 rzhao271 added the ~verification-steps-needed Steps to verify are needed (with bot comment) label Sep 30, 2022
@VSCodeTriageBot
Copy link
Collaborator

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

@VSCodeTriageBot VSCodeTriageBot added verification-steps-needed Steps to verify are needed for verification and removed ~verification-steps-needed Steps to verify are needed (with bot comment) labels Sep 30, 2022
@aeschli
Copy link
Contributor Author

aeschli commented Oct 3, 2022

To verify:

  • open a file in VS Code and collapse a region
  • close VS Code
  • use a different editor and add some new lines to the file at the beginning
  • open vscode on the file
  • verify that there's no stale folding region. Instead, the region will be expanded

@aeschli aeschli removed the verification-steps-needed Steps to verify are needed for verification label Oct 3, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

[folding] skip line number change test when restoring state #159032 microsoft/vscode
3 participants
@aeschli @rzhao271 @VSCodeTriageBot