Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Web Extension no longer works #162240

Closed
joyceerhl opened this issue Sep 28, 2022 · 15 comments
Closed

Install Web Extension no longer works #162240

joyceerhl opened this issue Sep 28, 2022 · 15 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@joyceerhl
Copy link
Contributor

  1. Serve a local dev build of a web extension which ships as builtin on insiders.vscode.dev over https using a task like
{
	"version": "2.0.0",
	"tasks": [
		{
			"label": "Serve web extension over https",
			"type": "shell",
			"command": "mkcert localhost 127.0.0.1; npx --yes serve --ssl-cert localhost+1.pem --ssl-key localhost+1-key.pem --cors",
			"problemMatcher": []
		},
  1. Use Install Web Extension to install the extension in insiders.vscode.dev
  2. Reload
  3. Open Installed Web Extension Resource
  4. 🐛 see that the extension isn't reflected as installed from localhost
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions web Issues related to running VSCode in the web labels Sep 29, 2022
@sandy081 sandy081 added this to the September 2022 milestone Sep 29, 2022
@sandy081
Copy link
Member

It works for me when I am on default profile. But there is a bug installing an extension does not work in another profiles which I fixed just now. Can you please double check if this is the case?

@roblourens roblourens added the author-verification-requested Issues potentially verifiable by issue author label Sep 30, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 4, 2022

@joyceerhl Can you verify this issue has been fixed?

@joyceerhl
Copy link
Contributor Author

This still repros for me in insiders.vscode.dev @sandy081 with the steps above :/

@joyceerhl joyceerhl reopened this Oct 4, 2022
@sandy081 sandy081 modified the milestones: September 2022, October 2022 Oct 4, 2022
@sandy081
Copy link
Member

sandy081 commented Oct 4, 2022

@joyceerhl It worked for me when I added following web extension

https://eamodio.vscode-unpkg.net//eamodio/gitlens/12.2.2/extension

I have not tried the local dev build as I have not set it up. But lets catch up and sync on this.

@joyceerhl
Copy link
Contributor Author

It doesn't work for me when I install the following
https://github.vscode-unpkg.net/github/vscode-pull-request-github/0.51.2022092709/extension

After a reload (which is required for the newly installed web extension to take effect), I appear to be auto updated to the latest version of the extension
image

@sandy081
Copy link
Member

sandy081 commented Oct 6, 2022

Yeah this is expected. If there is a newer version it gets autoupdated. But is not the same problem as described in the issue?

@joyceerhl
Copy link
Contributor Author

Hm, isn't it the same issue? Having installed a specific version of a web extension, I'm told to reload to actually have the install take effect, but the reload causes the extension to be updated to the latest. Maybe the recommendation for users is to disable auto updating in this scenario?

@sandy081
Copy link
Member

sandy081 commented Oct 7, 2022

This is a developer action to side load an extension that is not in Marketplace. But it seems your extension exists in Marketplace and is not a common scenario to side load. This is same as side loading an extension in desktop using VSIX and you see the same behaviour. So you have to make sure to disable updates if this is the case.

@sandy081 sandy081 closed this as completed Oct 7, 2022
@joyceerhl
Copy link
Contributor Author

Sorry to reopen this, but I currently have updates disabled and my side loaded web extensions are still getting auto updated:

image

@joyceerhl joyceerhl reopened this Oct 13, 2022
@sandy081
Copy link
Member

It seems these are not side loaded instead they are builtin. If so they are auto updated independent of auto update flag. This flag is only for user installed extensions.

@sandy081 sandy081 added info-needed Issue requires more information from poster and removed author-verification-requested Issues potentially verifiable by issue author labels Oct 19, 2022
@joyceerhl
Copy link
Contributor Author

Can builtin extensions not disable updates when side loaded?

@sandy081
Copy link
Member

Yes, when side loaded / installed by user, they won't be auto updated. In fact, they shall not be shown in built in extensions section in that case.

@joyceerhl
Copy link
Contributor Author

I'm seeing that when I sideload a builtin extension, ✅ they are not shown in @builtin , ❌ they are auto updated on reload, regardless of my setting configuration. I just confirmed that this is the case on insiders.vscode.dev, and it did not used to be the case till the last 1-2 releases.

@sandy081
Copy link
Member

I'm seeing that when I sideload a builtin extension, ✅ they are not shown in @Builtin

This should be shown as user installed extension because it was side-loaded so that you can also remove it. I think that's the bug.

@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Oct 26, 2022
sandy081 added a commit that referenced this issue Oct 26, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 26, 2022
formigoni pushed a commit to formigoni/vscode that referenced this issue Oct 27, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 28, 2022
@joyceerhl
Copy link
Contributor Author

Thank you @sandy081, works great now 🎉 😭 🥳 🙏

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

5 participants