-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typings issues with TestInstantiationService
#164297
Labels
Milestone
Comments
alexr00
added a commit
that referenced
this issue
Nov 2, 2022
alexr00
added a commit
that referenced
this issue
Nov 2, 2022
sandy081
added a commit
that referenced
this issue
Nov 4, 2022
sandy081
added a commit
that referenced
this issue
Nov 4, 2022
Tyriar
added a commit
that referenced
this issue
Nov 8, 2022
andreamah
added a commit
that referenced
this issue
Nov 9, 2022
This was referenced Nov 9, 2022
mjbvz
added a commit
to mjbvz/vscode
that referenced
this issue
Nov 11, 2022
mjbvz
added a commit
that referenced
this issue
Nov 11, 2022
roblourens
added a commit
that referenced
this issue
Nov 11, 2022
roblourens
added a commit
that referenced
this issue
Nov 11, 2022
rebornix
added a commit
that referenced
this issue
Nov 11, 2022
rebornix
added a commit
that referenced
this issue
Nov 11, 2022
mjbvz
added a commit
to mjbvz/vscode
that referenced
this issue
Nov 14, 2022
mjbvz
added a commit
that referenced
this issue
Nov 14, 2022
VSCodeTriageBot
added
the
unreleased
Patch has not yet been released in VS Code Insiders
label
Nov 14, 2022
5 tasks
VSCodeTriageBot
added
insiders-released
Patch has been released in VS Code Insiders
and removed
unreleased
Patch has not yet been released in VS Code Insiders
labels
Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Due to an oversight,
TestInstantiationService.createInstance()
does not enforce arguments or its return type. Fixing this exposes around 80 typings errors in our codebase that should be addressedTo fix this issue in your code:
In
instantionService
, comment out the first signature forcreateInstance
. (Do not check in this change. I will check in the change to the signature once all error have been fixed)Now look at the file assigned to you and fix the type error (you may need to restart the compile since we are changing such a core type)
Affected files
src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts
@meganrogge @Tyriarsrc/vs/workbench/contrib/terminal/test/browser/links/terminalUriLinkDetector.test.ts
@meganrogge @Tyriarsrc/vs/workbench/contrib/terminal/test/browser/links/terminalLocalLinkDetector.test.ts
@meganrogge @Tyriarsrc/vs/workbench/contrib/terminal/test/browser/links/terminalLinkManager.test.ts
@meganrogge @Tyriarsrc/vs/workbench/contrib/notebook/test/browser/contrib/notebookOutline.test.ts
@rebornixsrc/vs/workbench/services/dialogs/test/electron-sandbox/fileDialogService.test.ts
@alexr00src/vs/workbench/contrib/terminal/test/common/history.test.ts
@meganroggesrc/vs/workbench/contrib/tasks/test/browser/taskTerminalStatus.test.ts
@meganroggesrc/vs/workbench/contrib/search/test/common/searchResult.test.ts
@andreamahsrc/vs/workbench/contrib/search/test/browser/searchViewlet.test.ts
@andreamahsrc/vs/workbench/contrib/search/test/browser/searchActions.test.ts
@andreamahsrc/vs/workbench/contrib/notebook/test/browser/notebookKernelService.test.ts
@mjbvzsrc/vs/workbench/contrib/notebook/test/browser/notebookExecutionService.test.ts
@roblourenssrc/vs/workbench/contrib/notebook/test/browser/notebookEditorModel.test.ts
@mjbvzsrc/vs/workbench/contrib/extensions/test/electron-browser/extensionsViews.test.ts
@sandy081src/vs/workbench/contrib/extensions/test/electron-browser/extensionsActions.test.ts
@sandy081src/vs/editor/contrib/suggest/test/browser/suggestInlineCompletions.test.ts
@hedietsrc/vs/workbench/api/test/browser/mainThreadWorkspace.test.ts
@jriekensrc/vs/platform/terminal/test/common/requestStore.test.ts
@TyriarThe text was updated successfully, but these errors were encountered: