Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jade] Incorrect highlighting in strings with inline tags #1765

Closed
mrmlnc opened this issue Jan 4, 2016 · 7 comments
Closed

[jade] Incorrect highlighting in strings with inline tags #1765

mrmlnc opened this issue Jan 4, 2016 · 7 comments
Assignees
@aeschli
Labels
languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@mrmlnc
Copy link
Contributor

mrmlnc commented Jan 4, 2016

VS Code version:
0.10.6

Code:

p #[code samp] — Regular text. #[samp This is sample text] more text.

Description:
If you try to write a dot in a inline tag (tag Interpolation), text highlighting changes.

Gif:
2016-01-04_15-44-32
@joaomoreno joaomoreno added this to the Backlog milestone Jan 5, 2016
@aeschli aeschli mentioned this issue Jan 5, 2016
Closed
@aeschli
Copy link
Contributor

aeschli commented Jan 5, 2016

This issue was moved to davidrios/jade-tmbundle#67

@aeschli aeschli closed this as completed Jan 5, 2016
@aeschli aeschli added languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jan 13, 2016
@aeschli aeschli reopened this Jan 13, 2016
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Jan 13, 2016
@mrmlnc
Copy link
Contributor Author

mrmlnc commented Sep 2, 2016 •
edited
Loading

@aeschli, as I understand, this issue is related to the bug (feature) in vscode-textmate?

I ask this because I can fix Jade tmLanguage in VS Code (including other issues aka small refactoring). Does it make sense to do it?

UPD: And if it makes sense, then use PR or create demo extension?

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Sep 5, 2016 •
edited
Loading

@aeschli, you can see demo extension in VS Code 1.5.0

https://github.com/mrmlnc/vscode-jade-syntax

Correct highlighting for string with inline tags (fix for this issue) and correct highlighting of text in inline tags

image

Support for HTML comments

code - insiders_2016-09-06_02-01-15

Both types (buf/unbuf) comments is a just comments

code - insiders_2016-09-06_02-01-31

@mrmlnc mrmlnc mentioned this issue Sep 9, 2016
Closed
@aeschli
Copy link
Contributor

aeschli commented Sep 9, 2016

We should fix that in https://github.com/Microsoft/vscode-textmate

@aeschli aeschli mentioned this issue Sep 9, 2016
Closed
@aeschli
Copy link
Contributor

aeschli commented Sep 9, 2016

This issue was moved to microsoft/vscode-textmate#22

@aeschli aeschli closed this as completed Sep 9, 2016
@ramya-rao-a ramya-rao-a removed the bug Issue identified by VS Code Team member as probable bug label Sep 28, 2016
@ramya-rao-a
Copy link
Contributor

Moving to next milestone, as this cannot be verified at the moment

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Sep 28, 2016
@ramya-rao-a ramya-rao-a modified the milestones: October 2016, Backlog Sep 28, 2016
@Tyriar Tyriar removed this from the October 2016 milestone Sep 30, 2016
@Tyriar Tyriar removed the bug Issue identified by VS Code Team member as probable bug label Sep 30, 2016
@Tyriar
Copy link
Member

Tyriar commented Sep 30, 2016

Removing bug to get it out of the verification queue

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joaomoreno @Tyriar @aeschli @mrmlnc @ramya-rao-a