Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jade/pug] Correct highlighting for string with inline tags #11759

Closed
wants to merge 1 commit into from
Closed

[jade/pug] Correct highlighting for string with inline tags #11759

wants to merge 1 commit into from

Conversation

mrmlnc
Copy link
Contributor

@mrmlnc mrmlnc commented Sep 9, 2016 •
edited
Loading

Hello, @aeschli,

This PR is fix for #1765.

Before fix:

code - oss_2016-09-09_13-32-07

After fix:

code - oss_2016-09-09_13-32-54

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.877% when pulling 2245aed on mrmlnc:fix-1765 into 756ff78 on Microsoft:master.

@aeschli
Copy link
Contributor

aeschli commented Sep 9, 2016

@mrmlnc Thanks for looking at this. I'd rather not fork from the original grammar. We should rather fix https://github.com/Microsoft/vscode-textmate. I created microsoft/vscode-textmate#22

@aeschli aeschli closed this Sep 9, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrmlnc @coveralls @aeschli @msftclas