Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot login with GH #180803

Closed
jrieken opened this issue Apr 25, 2023 · 6 comments
Closed

Cannot login with GH #180803

jrieken opened this issue Apr 25, 2023 · 6 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@jrieken
Copy link
Member

jrieken commented Apr 25, 2023

Blocks testing #180745

  • I have setup a fresh ubuntu 22 VM, using todays insiders
  • select "Tun on Remote Access"
  • GH auth flow starts
  • it hangs forever, nothing special in logs nor on console

Screenshot 2023-04-25 at 12 00 20

2023-04-25 11:51:22.654 [info] Reading sessions from keychain...
2023-04-25 11:51:22.654 [info] Getting sessions for all scopes...
2023-04-25 11:51:22.654 [info] Getting sessions for user:email...
2023-04-25 11:51:22.654 [info] Got 0 sessions for ...
2023-04-25 11:51:22.654 [info] Got 0 sessions for user:email...
2023-04-25 11:51:23.310 [info] Getting sessions for all scopes...
2023-04-25 11:51:23.310 [info] Got 0 sessions for ...
2023-04-25 11:52:04.300 [info] Getting sessions for read:org,user:email...
2023-04-25 11:52:04.300 [info] Got 0 sessions for read:org,user:email...
2023-04-25 11:52:06.507 [info] Logging in for the following scopes: read:org user:email
2023-04-25 11:52:06.508 [info] Trying without local server... (read:org user:email)
2023-04-25 11:56:38.198 [error] User Cancelled
2023-04-25 11:56:41.791 [info] Trying with local server... (read:org user:email)
2023-04-25 11:57:05.845 [error] User Cancelled
2023-04-25 11:57:19.254 [info] Reading sessions from keychain...
2023-04-25 11:57:19.254 [info] Getting sessions for all scopes...
2023-04-25 11:57:19.254 [info] Getting sessions for user:email...
2023-04-25 11:57:19.254 [info] Got 0 sessions for ...
2023-04-25 11:57:19.254 [info] Got 0 sessions for user:email...
2023-04-25 11:57:19.880 [info] Getting sessions for all scopes...
2023-04-25 11:57:19.880 [info] Got 0 sessions for ...
2023-04-25 11:57:30.351 [info] Getting sessions for user:email...
2023-04-25 11:57:30.351 [info] Got 0 sessions for user:email...
2023-04-25 11:57:33.729 [info] Logging in for the following scopes: user:email
2023-04-25 11:57:33.734 [info] Trying without local server... (user:email)
2023-04-25 11:59:46.723 [info] Reading sessions from keychain...
2023-04-25 11:59:46.723 [info] Getting sessions for all scopes...
2023-04-25 11:59:46.723 [info] Getting sessions for user:email...
2023-04-25 11:59:46.723 [info] Got 0 sessions for ...
2023-04-25 11:59:46.723 [info] Got 0 sessions for user:email...
2023-04-25 11:59:47.654 [info] Getting sessions for all scopes...
2023-04-25 11:59:47.654 [info] Got 0 sessions for ...
2023-04-25 11:59:51.513 [info] Getting sessions for read:org,user:email...
2023-04-25 11:59:51.513 [info] Got 0 sessions for read:org,user:email...
2023-04-25 11:59:54.075 [info] Logging in for the following scopes: read:org user:email
2023-04-25 11:59:54.080 [info] Trying without local server... (read:org user:email)
Version: 1.78.0-insider
Commit: 2902f278ad8e2d830fa6883d3d8fd7b5c2ca59e9
Date: 2023-04-25T05:55:39.650Z
Electron: 22.4.8
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Linux arm64 5.15.0-70-generic
Sandboxed: Yes
@jrieken jrieken changed the title Cannot login in with GH Cannot login with GH Apr 25, 2023
@TylerLeonhardt
Copy link
Member

@jrieken is this instance of VS Code able to openExternal anything?

If you need a tool to test this, try my open external extension:
https://marketplace.visualstudio.com/items?itemName=TylerLeonhardt.open-external

If you cancel that auth flow again, the next flow is the Device Code Flow which wouldn't require opening in a browser at all so that one should work for you.

@TylerLeonhardt TylerLeonhardt added the info-needed Issue requires more information from poster label Apr 25, 2023
@jrieken
Copy link
Member Author

jrieken commented Apr 25, 2023

If you cancel that auth flow again, the next flow is the Device Code Flow which wouldn't require opening in a browser at all so that one should work for you.

That didn't happened. I cancelled and it asked me to try somehow else but w/o success.

@jrieken is this instance of VS Code able to openExternal anything?

That was very likely the cause (no logging tho...). I restarted the VM and then FF was being opened. I could login to GH but because I am running VS Code unzipped FF isn't able to call back into vs code...

@TylerLeonhardt
Copy link
Member

I could login to GH but because I am running VS Code unzipped FF isn't able to call back into vs code...

GitHub Auth flow has 3 flows:

  1. using vscode:// Uri handler (fastest when it works)
  2. using localhost (for users who don't have vscode:// handling setup)
  3. using Device Code flow (when all else fails)

It starts with the first, and if you cancel it says "wanna try a different way" and if you say "yes" it goes to number 2 and if you cancel it says "wanna try a different way" and if you say "yes" it goes to number 3

Is this not what you experienced?

@jrieken
Copy link
Member Author

jrieken commented Apr 26, 2023

I did experience that but none had success. Tho, I might have canceled between 2 and 3 because it isn't really obvious that it tries yet another way and isn't stuck between 1 and 2. Why not name the options it is trying with?

@TylerLeonhardt
Copy link
Member

@jrieken I've added this to indicate the different flow that you will be using next so that it's apparent that it's different.

To figure out why you can't log in, I'll need the GitHub Authentication logs... can you go through it again and get those for me?

@VSCodeTriageBot
Copy link
Collaborator

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants