Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeCheckboxChangeEvent: doc comment should say items #183826

Closed
aeschli opened this issue May 30, 2023 · 0 comments · Fixed by #183931
Closed

TreeCheckboxChangeEvent: doc comment should say items #183826

aeschli opened this issue May 30, 2023 · 0 comments · Fixed by #183931
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Milestone
May 2023

Comments

@aeschli
Copy link
Contributor

aeschli commented May 30, 2023

Testing #183549

		/**
		* The item that was checked or unchecked.
		*/
		readonly items: ReadonlyArray<[T, TreeItemCheckboxState]>;

As the event can list multiple items, the doc comment should say items
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues labels May 31, 2023
@alexr00 alexr00 added this to the May 2023 milestone May 31, 2023
@alexr00 alexr00 mentioned this issue May 31, 2023
Merged
alexr00 added a commit that referenced this issue May 31, 2023
@alexr00
Tree checkbox item -> items
e3414be 
Fixes #183826
alexr00 added a commit that referenced this issue May 31, 2023
@alexr00
Tree checkbox item -> items (#183931)
44ef5cc 
Fixes #183826
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 31, 2023
@Tyriar Tyriar added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Tree checkbox item -> items microsoft/vscode
4 participants
@Tyriar @aeschli @alexr00 @VSCodeTriageBot