env set in my fish config prevails over what I set in the env var collection

[meganrogge]

Testing #182970

	const term2 = vscode.window.createTerminal({
		name: `Ext Terminal tranisent #${NEXT_TERM_ID++}`,
		isTransient: true,
		shellPath: 'fish'
	} as any);
	const collection = context.environmentVariableCollection;
		collection.replace('FOO', 'REPLACED', { applyAtShellIntegration: true, applyAtProcessCreation: false });
		collection.append('APPENDING', 'appending', { applyAtShellIntegration: true, applyAtProcessCreation: false })
		collection.prepend('PREPENDING', 'prepending', { applyAtShellIntegration: true, applyAtProcessCreation: false });

[Tyriar]

This is because of the same problem that caused #184191

[karrtikr]

@Tyriar #184191 appears to be closed now, does that mean this has been fixed?

[Tyriar]

No, this issue is about fish acting atypical in that it applies the environment before fish.config is applied. This is because of how the automatic injection works in fish via an environment variable. Still not sure how we can handle this.

[karrtikr]

Discussed offline, maybe we could use the first pre exec hook in fish to run shell integration, instead of XDG_DATA_DIRS.

[meganrogge]

Nice 👍