Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Crashes when running Smoke Tests #186175

Closed
isidorn opened this issue Jun 26, 2023 · 4 comments
Closed

Native Crashes when running Smoke Tests #186175

isidorn opened this issue Jun 26, 2023 · 4 comments
Assignees
@deepak1556
Labels
debt Code quality issues electron Issues and items related to Electron freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
August 2023

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2023

My pipeline https://dev.azure.com/vscode/VSCode/_build/results?buildId=96901&view=logs&j=15f6beb8-c39c-5fa4-f1fe-6e73c89d1002&t=f548697b-f1e3-56d7-b20f-10575b2a648b&s=96ac2280-8cb4-5df5-99de-dd2da759617d

PR that triggered it #185658

Native crashes:
logs-linux-x64-smoke-1.zip

@deepak1556 let me know if you need more details from my side
@isidorn isidorn mentioned this issue Jun 26, 2023
Merged
@bpasero bpasero added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Jun 26, 2023
@bpasero
Copy link
Member

bpasero commented Jun 26, 2023

Above are just the logs, attaching crash dumps:

crash-dump-linux-x64-smoke-1.zip

@deepak1556
Copy link
Collaborator

This would be https://github.com/microsoft/vscode-internalbacklog/issues/3454 affecting the OSS electron builds since they don't contain the fix. I will keep this issue open to upstream the fix.

The crash itself is just a side effect of the workbench terminating the connection with the extension host eagerly, might want to investigate if the message port was disconnected gracefully.

@deepak1556 deepak1556 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) debt Code quality issues electron Issues and items related to Electron labels Jun 26, 2023
@deepak1556 deepak1556 added this to the July 2023 milestone Jun 26, 2023
@rzhao271 rzhao271 modified the milestones: July 2023, August 2023 Jul 21, 2023
@deepak1556
Copy link
Collaborator

Change has been upstreamed electron/electron#39335

@deepak1556
Copy link
Collaborator

Addressed in #189904

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
debt Code quality issues electron Issues and items related to Electron freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
August 2023
Development

No branches or pull requests
4 participants
@bpasero @deepak1556 @isidorn @rzhao271