remove workbench/contrib/experiments

[isidorn]

Ref https://github.com/microsoft/vscode-internalbacklog/issues/2855

Removes unused workbench/contrib/experiments
All tests are green and I ran VS Code out of Source and it looks OK.

fyi @bpasero

[isidorn]

Code OSS check failed due to flaky smoke test.
@bpasero @sandy081 I just updated with latest from main to re-trigger the flaky smoke test.

[bpasero]

@isidorn please consider to take a moment to drill a bit into, we have all the diag available.

here in this case I see a lot of native crashes:

You can report these to Deepak.

[isidorn]

@bpasero can you clarify what I should do here?
I just see the Smoke Test failures on Linux Remote https://dev.azure.com/vscode/VSCode/_build/results?buildId=96901&view=logs&j=15f6beb8-c39c-5fa4-f1fe-6e73c89d1002&t=f548697b-f1e3-56d7-b20f-10575b2a648b

Where do you see native crashes? And should I create new issues for Deepak?

[bpasero]

@isidorn you need to drill into the attachments of the build to find all the logs and crash dumps.

The arrow brings you back:

Then see "Related" artefacts:

This shows logs for all tests:

If crash dumps have any size > 100kb, thats a good hint that there are native crash dumps:

You can then file an issue with the crash dump attached. There are many here so maybe picking one is sufficient.

Btw this does not mean these crashes are related to your change.

[isidorn]

Thanks Ben! I just filled #186175

[isidorn]

@bpasero sorry I got stuck. I ran the remote smoke tests locally and I can indeed reproduce the problem. I ran them via
yarn smoketest-no-compile --remote --tracing
Same what our build machine does. The build machine shows the following error:
Error: Timeout: get text content '.monaco-workbench .statusbar-item[id="status.host"]' after 30 seconds

When I run it locally I see that element exists. Do you have any hints what might be going on?

[bpasero]

@isidorn please check for each file you delete if any code still depends on any of it. For example if you search for enableExperiments, all of that I think needs to go away. Maybe there is more.

[isidorn]

@bpasero thanks. I did that already, but I double checked now and no files depend on file names I deleted. I also did a full text search and we are good - nothing found.

As for the remaining instances of enableExperiments, that is for the AssignementService. As far as I understand we still need that one for our new way of running experiments. @sbatten is the owner of that one and he might confirm.

[bpasero]

i brought it up because I think the smoke tests then ran for me when removing that. I have a feeling that the remote server fails to start in the smoke tests, you can see how the window quickly closes while the remote is setting up. I was not able to find the underlying reason though, but maybe its related to that setting.

[isidorn]

I think I found the issue. I removed the registration of workbench.enableExperiments setting. We still need that for our assignment service. I will bring it back and re-trigger tests.

So thanks Ben and the smoke tests 👏

[isidorn]

Ok. Tests passed. @bpasero can you just approve via review. Thank you!

I am having follow up discussions with Logan to see if we really need the AssignmentService

[isidorn]

@lramos15 confirmed that we indeed need the AssignmentService for our new experimentation framework.
So we are good here 👏