Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom tree view looses focussed checkbox on toggle #186306

Closed
bpasero opened this issue Jun 27, 2023 · 2 comments · Fixed by #186906
Closed

Custom tree view looses focussed checkbox on toggle #186306

bpasero opened this issue Jun 27, 2023 · 2 comments · Fixed by #186906
Assignees
@alexr00
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Milestone
July 2023

Comments

@bpasero
Copy link
Member

bpasero commented Jun 27, 2023

Testing #186164

It almost looks like we do a tree refresh and then loose the focus on the checkbox:

Recording 2023-06-27 at 11 59 28 (1)

This was tested with the extension sample of the npm explorer, so might also be related to that?
@bpasero bpasero added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 27, 2023
@alexr00
Copy link
Member

alexr00 commented Jun 27, 2023

Good find, that is exactly what we do.

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 27, 2023
@alexr00 alexr00 added this to the June 2023 milestone Jun 27, 2023
@alexr00 alexr00 added the tree-views Extension tree view issues label Jun 27, 2023
@alexr00
Copy link
Member

alexr00 commented Jun 29, 2023

This is going to be a more involved change than we should take during endgame. I will fix after endgame.

@alexr00 alexr00 modified the milestones: June 2023, July 2023 Jun 29, 2023
@alexr00 alexr00 mentioned this issue Jul 3, 2023
Merged
alexr00 added a commit that referenced this issue Jul 3, 2023
@alexr00
Custom tree view looses focussed checkbox on toggle
28f8ada 
Fixes #186306
alexr00 added a commit that referenced this issue Jul 3, 2023
@alexr00
Custom tree view looses focussed checkbox on toggle (#186906)
7c34ea4 
Fixes #186306
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 3, 2023
@joyceerhl joyceerhl added verified Verification succeeded and removed verified Verification succeeded labels Jul 26, 2023
@DonJayamanne DonJayamanne added the verified Verification succeeded label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Custom tree view looses focussed checkbox on toggle microsoft/vscode
5 participants
@bpasero @DonJayamanne @joyceerhl @alexr00 @VSCodeTriageBot