Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepending fails on zsh with only shell integration enabled #188875

Closed
Tracked by #20822
karrtikr opened this issue Jul 25, 2023 · 3 comments · Fixed by #191822
Closed
Tracked by #20822

Prepending fails on zsh with only shell integration enabled #188875

karrtikr opened this issue Jul 25, 2023 · 3 comments · Fixed by #191822
Assignees
@Tyriar
Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
August 2023

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Jul 25, 2023 •
edited
Loading

Testing #182970

envVarCollection.prepend('PS1', '(.venv) ', {
    applyAtProcessCreation: false,
    applyAtShellIntegration: true,
});

seems to fail on zsh shell:

image
@karrtikr karrtikr mentioned this issue Jul 25, 2023
Closed
22 tasks
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug api terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Jul 26, 2023
@Tyriar Tyriar added this to the Backlog milestone Jul 26, 2023
@Tyriar Tyriar mentioned this issue Jul 26, 2023
Closed
@Tyriar Tyriar modified the milestones: Backlog, August 2023 Aug 7, 2023
@Tyriar Tyriar modified the milestones: August 2023, September 2023 Aug 28, 2023
@karrtikr karrtikr mentioned this issue Aug 30, 2023
Closed
@karrtikr
Copy link
Contributor Author

Moving this to August same as the other issue: #191753

@karrtikr karrtikr modified the milestones: September 2023, August 2023 Aug 30, 2023
@karrtikr
Copy link
Contributor Author

Let me know if we're unable to fix this in time, in which case I'll stop prepending for zsh in Python extension.

@Tyriar
Copy link
Member

Tyriar commented Aug 30, 2023

Looking into it now

Tyriar added a commit that referenced this issue Aug 30, 2023
@Tyriar
Fix error in zsh si script
c69c908 
Fixes #188875
@Tyriar Tyriar mentioned this issue Aug 30, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 30, 2023
@ulugbekna ulugbekna added the verified Verification succeeded label Aug 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

Fix error in zsh si script microsoft/vscode
4 participants
@Tyriar @karrtikr @ulugbekna @vscodenpa