Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore using sysroot instead of LTS containers for building native modules in CI #189885

Closed
connor4312 opened this issue Aug 8, 2023 · 3 comments · Fixed by #192513
Closed

Explore using sysroot instead of LTS containers for building native modules in CI #189885

connor4312 opened this issue Aug 8, 2023 · 3 comments · Fixed by #192513
Assignees
@deepak1556
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Milestone
December / Januar...

Comments

@connor4312
Copy link
Member

Currently, these (the vscode-linux-build-agent:* images) are still on Node 16.
@lszomoru lszomoru assigned deepak1556 and unassigned lszomoru Aug 21, 2023
@lszomoru
Copy link
Member

@deepak1556, could you please take a look at this? Thanks!

@deepak1556
Copy link
Collaborator

I believe this was opened as a follow-up to #189886, I have added short-term workarounds in #189904. As mentioned in #189886 (comment) we cannot make the switch to Node 18 on these images without bumping the base image which won't happen soon. I can explore the long term solution of using sysroots as part of this issue instead.

@deepak1556 deepak1556 changed the title Update unit test docker images to Node 18 Explore using sysroot instead of LTS containers for building native modules in CI Aug 21, 2023
@deepak1556 deepak1556 added debt Code quality issues vscode-build VS Code build process issues engineering VS Code - Build / issue tracking / etc. labels Aug 21, 2023
@deepak1556 deepak1556 mentioned this issue Sep 8, 2023
Merged
3 tasks
@deepak1556
Copy link
Collaborator

Started work here #192513, overall looking good with nice results. Need some cleanup before it can be merged.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Projects
None yet
Milestone
December / January 2024
Development

Successfully merging a pull request may close this issue.

refactor: use sysroots on linux prod pipeline microsoft/vscode
5 participants
@deepak1556 @connor4312 @lszomoru @aiday-mar @vscodenpa