refactor: use sysroots on linux prod pipeline #192513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
deepak1556
force-pushed
the
robo/exp_sysroot
branch
17 times, most recently
from
46504fe to
6fca84a
Compare
deepak1556
force-pushed
the
robo/exp_sysroot
branch
3 times, most recently
from
5666069 to
762b33a
Compare
deepak1556
changed the title
deepak1556
force-pushed
the
robo/exp_sysroot
branch
3 times, most recently
from
a66607d to
21af479
Compare
This was referenced Nov 24, 2023
deepak1556
commented
Nov 24, 2023
| fi | ||
| done | ||
| condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true')) | ||
| displayName: Check GLIBC and GLIBCXX dependencies in remote/node_modules |
There was a problem hiding this comment.
For clients the check will be done during packaging deb and rpm steps, the server was missing this check so added a simple but effective one.
deepak1556
commented
Nov 24, 2023
| const spec = code.pipe(es.through( | ||
| async function () { | ||
| const that = this; | ||
| const dependencies = await dependenciesGenerator.getDependencies('rpm', binaryDir, product.applicationName, rpmArch); |
There was a problem hiding this comment.
Errors from getDependencies will be missed otherwise.
|
This is good for review, although I plan to merge only next milestone after some sanity testing during endgame. |
|
I don't see anything objectionable here, but I am also far from an expert on C compilation. |
rzhao271
reviewed
Nov 27, 2023
deepak1556
force-pushed
the
robo/exp_sysroot
branch
2 times, most recently
from
f96cf5a to
b047b7d
Compare
deepak1556
force-pushed
the
robo/exp_sysroot
branch
from
b047b7d to
6d5bf1b
Compare
joaomoreno
requested changes
Dec 8, 2023
deepak1556
force-pushed
the
robo/exp_sysroot
branch
from
6d5bf1b to
cf00227
Compare
joaomoreno
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189885
Fixes #192685
Depends on microsoft/vscode-linux-build-agent#43
TODO
libxkbfile-devto the sysroots, needed fornative-keymapOutcome of this experiment:
Install dependenciesstep without cacheBumps both client and server to
GLIBC >= 2.28andGLIBCXX >= 3.4.25