Explore capturing heap snapshot in CI and analyzing potential memory leaks #191920
Assignees
Labels
Milestone
Comments
|
The dev tools also show how an object is leaked, we could analyze the dependencies tree and figure out who is the "culprit" |
|
process.takeHeapSnapshot would be a good API for CI use case on desktop to capture from any non-sandboxed process (Main, Utility - Ext Host, Shared Process, Pty Agent) embedding V8 without using external CDP calls. In the case of sandboxed render process, prefer webContents.takeHeapSnapshot |
|
I find this topic super interesting as well! I have a prototype project https://github.com/SimonSiefke/vscode-memory-leak-finder that tries to find memory leaks by looking for leaking event listeners. notebook-test.mp4In the screencast, the event listener count increases from 1175 to 1206 which indicates that there might be a memory leak when opening and closing a notebook editor. The project is in the early phases and in the future I'm hoping to display more detailed output for the event listeners as well as making the tests less flaky. (sorry if I'm interrupting the discussion. I'm hoping that perhaps this could be useful for you) |
connor4312
added a commit
that referenced
this issue
Nov 15, 2023
This adds an `assertHeap` function that can be used in tests. It takes a heap snapshot, and asserts the state of classes in memory. This works in Node and the Electron sandbox, but is a no-op in the browser. Snapshots are process asynchronously and will report failures at the end of the suite. This method should be used sparingly (e.g. once at the end of a suite to ensure nothing leaked before), as gathering a heap snapshot is fairly slow, at least until V8 11.5.130 (https://v8.dev/blog/speeding-up-v8-heap-snapshots). When used, the function will ensure the test has a minimum timeout duration of 20s to avoid immediate failures. It takes options containing a mapping of class names, and assertion functions to run on the number of retained instances of that class. For example: ```ts assertSnapshot({ classes: { ShouldNeverLeak: count => assert.strictEqual(count, 0), SomeSingleton: count => assert(count <= 1), } }); ``` Closes #191920
connor4312
added a commit
that referenced
this issue
Nov 15, 2023
This adds an `assertHeap` function that can be used in tests. It takes a heap snapshot, and asserts the state of classes in memory. This works in Node and the Electron sandbox, but is a no-op in the browser. Snapshots are process asynchronously and will report failures at the end of the suite. This method should be used sparingly (e.g. once at the end of a suite to ensure nothing leaked before), as gathering a heap snapshot is fairly slow, at least until V8 11.5.130 (https://v8.dev/blog/speeding-up-v8-heap-snapshots). When used, the function will ensure the test has a minimum timeout duration of 20s to avoid immediate failures. It takes options containing a mapping of class names, and assertion functions to run on the number of retained instances of that class. For example: ```ts assertSnapshot({ classes: { ShouldNeverLeak: count => assert.strictEqual(count, 0), SomeSingleton: count => assert(count <= 1), } }); ``` Closes #191920
connor4312
added a commit
that referenced
this issue
Nov 15, 2023
This adds an `assertHeap` function that can be used in tests. It takes a heap snapshot, and asserts the state of classes in memory. This works in Node and the Electron sandbox, but is a no-op in the browser. Snapshots are process asynchronously and will report failures at the end of the suite. This method should be used sparingly (e.g. once at the end of a suite to ensure nothing leaked before), as gathering a heap snapshot is fairly slow, at least until V8 11.5.130 (https://v8.dev/blog/speeding-up-v8-heap-snapshots). When used, the function will ensure the test has a minimum timeout duration of 20s to avoid immediate failures. It takes options containing a mapping of class names, and assertion functions to run on the number of retained instances of that class. For example: ```ts assertSnapshot({ classes: { ShouldNeverLeak: count => assert.strictEqual(count, 0), SomeSingleton: count => assert(count <= 1), } }); ``` Closes #191920
vscodenpa
added
the
unreleased
vscodenpa
added
insiders-released
Yoyokrazy
added a commit
that referenced
this issue
Nov 17, 2023
commit b277683 Author: Rob Lourens <roblourens@gmail.com> Date: Fri Nov 17 12:43:34 2023 -0600 Make filtered responses even less visible (#198551) commit a086a83 Author: Aaron Munger <aamunger@microsoft.com> Date: Fri Nov 17 10:09:54 2023 -0800 fix protected field commit 773e2b4 Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Fri Nov 17 18:40:04 2023 +0100 Fixes #198432 commit fc6b857 Author: João Moreno <joao.moreno@microsoft.com> Date: Fri Nov 17 18:54:55 2023 +0100 Workaround for AZDO artifact throttling (#198545) * download and extract in main thread, spin off other threads for rest of IO * remove limiters: everything runs on workers now * add docs commit 74d6858 Author: Aaron Munger <aamunger@microsoft.com> Date: Thu Nov 16 14:23:48 2023 -0800 naming, formatting commit ac59af4 Author: aamunger <aamunger@microsoft.com> Date: Thu Nov 16 08:53:20 2023 -0800 remove mock variables commit 6f6d0a7 Author: aamunger <aamunger@microsoft.com> Date: Wed Nov 15 10:00:12 2023 -0800 display variables provided by extension commit c282c5a Author: aamunger <aamunger@microsoft.com> Date: Tue Nov 14 13:13:59 2023 -0800 implement extension host proxy commit 85a73e7 Author: aamunger <aamunger@microsoft.com> Date: Mon Nov 13 16:31:44 2023 -0800 fix tree layout, add proposed API commit d39e29e Author: aamunger <aamunger@microsoft.com> Date: Mon Nov 13 10:40:08 2023 -0800 Ive created a monster commit f76f831 Author: Aaron Munger <aamunger@microsoft.com> Date: Thu Nov 9 15:47:10 2023 -0800 more instantiation fixes commit 9b313c3 Author: aamunger <aamunger@microsoft.com> Date: Thu Nov 9 09:19:54 2023 -0800 move view into debug container commit 449c95f Author: Aaron Munger <aamunger@microsoft.com> Date: Mon Nov 6 15:35:50 2023 -0800 more boilerplate commit 58c2ebe Author: Aaron Munger <aamunger@microsoft.com> Date: Mon Nov 6 15:30:40 2023 -0800 ..... commit 36d4b03 Author: Aaron Munger <aamunger@microsoft.com> Date: Mon Nov 6 15:08:54 2023 -0800 new classes commit 21d2297 Author: Rob Lourens <roblourens@gmail.com> Date: Fri Nov 17 10:54:53 2023 -0600 Make filtered responses less readable and not copyable (#198539) commit 9d596ed Merge: c2e58d5 12f6838 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri Nov 17 08:41:10 2023 -0800 Merge pull request #198535 from microsoft/tyriar/198358 Correct sticky scroll bg color in terminal editors commit c2e58d5 Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Fri Nov 17 16:55:06 2023 +0100 Fixes #198516 commit 96df831 Author: Peng Lyu <penn.lv@gmail.com> Date: Fri Nov 17 08:06:47 2023 -0800 Fix #198492. Avoid action name duplicate (#198527) commit 12f6838 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri Nov 17 07:46:08 2023 -0800 Correct sticky scroll bg color in terminal editors Fixes #198358 commit 19bb924 Merge: 40648dd 5bcc2ad Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri Nov 17 07:45:24 2023 -0800 Merge pull request #198532 from microsoft/tyriar/css Remove now unused css commit 40648dd Merge: 77da82c 28a7bc4 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri Nov 17 07:34:30 2023 -0800 Merge pull request #198403 from rehmsen/hermetic-xterm-test Make xtermTerminal.test.ts hermetic. commit 77da82c Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Fri Nov 17 16:32:12 2023 +0100 aux window - fix regression when dropping over window location (#198529) commit 5bcc2ad Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri Nov 17 07:30:22 2023 -0800 Remove now unused css commit 2d424c7 Author: John Murray <johnm@georgejames.com> Date: Fri Nov 17 15:24:22 2023 +0000 Add 'Lock Group' button on aux windows (#182265) (#182294) * Add 'Lock Group' button (#182265) * Add `isAuxiliaryEditorPart` context key * Show `Lock Group` action button only on auxiliary windows * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> commit 5dc8011 Author: Rob Lourens <roblourens@gmail.com> Date: Fri Nov 17 09:15:41 2023 -0600 Add chat progress message api (#198528) * Add chat agent progress message update to model * Add chat progress messages above content * Check style, center spinner commit aa61b56 Author: João Moreno <joao.moreno@microsoft.com> Date: Fri Nov 17 15:03:32 2023 +0100 Fix issue in counting artifacts on retries, improve parallelization (#198488) * try to parallelize downloads * improved logs * allow 5 parallel downloads * fake browser requests * fix artifacts processed file in retries commit f3dfca4 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Fri Nov 17 12:32:44 2023 +0100 "copy handles symbolic links" unit test fails locally, preventing other tests from running (fix #198470) (#198486) commit 23c0f77 Author: Ulugbek Abdullaev <ulugbekna@gmail.com> Date: Fri Nov 17 12:12:04 2023 +0100 inlay hints: fix: trace logging prints json-ified object not `[object]` (#198511) commit 092bc73 Author: Arvid Lunnemark <arvid.lunnemark@gmail.com> Date: Fri Nov 17 02:57:50 2023 -0800 Update condition names to allow node (#198274) update condition names to allow node commit af63c41 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Fri Nov 17 11:36:50 2023 +0100 aux window - hopefully fix contextview issue commit 634df63 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Fri Nov 17 10:30:17 2023 +0100 aux window - limit zen mode to main part for now commit a76b835 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Fri Nov 17 10:14:23 2023 +0100 aux window - limit centered layout to main part for now commit cb33247 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Fri Nov 17 09:32:24 2023 +0100 aux window - make `getMaximumEditorDimensions` work commit c72dd8c Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 18:15:21 2023 +0100 aux window - introduce event for new aux parts commit 7f76fab Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 17:44:06 2023 +0100 aux window - improve layout for aux windows commit c2283b6 Merge: cc08867 1cf3ec8 Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Date: Fri Nov 17 11:47:47 2023 +0100 Merge pull request #198448 from microsoft/aiday/turningOffTheEditorGutterIcon Turning off the editor gutter icon commit cc08867 Author: Martin Aeschlimann <martinae@microsoft.com> Date: Fri Nov 17 11:40:21 2023 +0100 merge theme rules for css/less/scss variables (#197657) commit edc4698 Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Date: Fri Nov 17 11:39:09 2023 +0100 Making the editor toolbar sparkle icon appear on focus of the editor and when the inline chat is not visible yet (#198458) changed the condition for the sparkle to appear commit 7b9833b Author: Martin Aeschlimann <martinae@microsoft.com> Date: Fri Nov 17 11:01:46 2023 +0100 Removes ms-vscode-remote.remote-wsl-recommender (#198502) bump distro commit e5ec7d2 Author: Benjamin Simmonds <44439583+benibenj@users.noreply.github.com> Date: Fri Nov 17 10:54:25 2023 +0100 Toggle Editor Actions in Titlebar when Tab Bar is Hidden (#198494) * Toggle Editor Actions in Titlebar when tab bar is hidden commit d704c62 Author: Martin Aeschlimann <martinae@microsoft.com> Date: Fri Nov 17 10:46:13 2023 +0100 Support for followups in InlineChat (#198500) * followup * support provideFollowups in inline chat commit 54b8f6a Author: Johannes Rieken <johannes.rieken@gmail.com> Date: Fri Nov 17 10:02:28 2023 +0100 avoid command id duplication (#198496) #198492 commit dd9e1d5 Author: Matt Bierner <matb@microsoft.com> Date: Thu Nov 16 23:10:28 2023 -0800 Pick up latest TS for building VS Code (#198477) commit ed684fc Author: Peng Lyu <penn.lv@gmail.com> Date: Thu Nov 16 18:17:42 2023 -0800 Reuse chat widget and support status actions (#198479) * Reuse chat widget and support status * Update cell chat actions commit 6805bb6 Author: Matt Bierner <matb@microsoft.com> Date: Thu Nov 16 18:07:09 2023 -0800 Hook up mapped code edits experiment for TS (#198478) For microsoft/TypeScript#55406 commit 77dc879 Author: John Murray <johnm@georgejames.com> Date: Thu Nov 16 22:46:41 2023 +0000 Add `typescript.implementationsCodeLens.showOnInterfaceMethods` setting (#136282) (#198419) * Add `typescript.implementationsCodeLens.showOnInterfaceMethods` setting (#136282) * Update codelenses when `typescript.referencesCodeLens.showOnAllFunctions` changes * Improve handling of disposables commit 678f6a5 Merge: 4f86653 860005c Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 14:20:53 2023 -0800 Merge pull request #198474 from microsoft/tyriar/198013_2 Add sticky scroll tooltip and command nav actions to panel commit 4f86653 Author: Matt Bierner <matb@microsoft.com> Date: Thu Nov 16 14:18:43 2023 -0800 Add missing disposable registration (#198473) commit 4f1065b Merge: 0701bc6 9c47447 Author: Megan Rogge <merogge@microsoft.com> Date: Thu Nov 16 14:03:19 2023 -0800 Merge pull request #198371 from microsoft/merogge/bug check if active instance before updating / showing accessible view on dynamic terminal content commit 0701bc6 Merge: dff0e3e a1c3d38 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 14:02:44 2023 -0800 Merge pull request #198464 from microsoft/tyriar/195804_3 Remove window usage from link terminalContrib commit 860005c Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 13:45:39 2023 -0800 Add sticky scroll tooltip and command nav actions to panel Fixes #198013 commit dff0e3e Merge: 0d552b5 1c7839a Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 13:31:17 2023 -0800 Merge pull request #198463 from microsoft/tyriar/198278 Windows: Polish single prompt line and clear/cls behavior commit 1c7839a Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 13:05:21 2023 -0800 Start next command in tests to finish previous command commit 0d552b5 Merge: c855616 33244ee Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 10:44:02 2023 -0800 Merge pull request #198438 from microsoft/tyriar/198437 Use a single overview ruler indicator for command nav commit a1c3d38 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 10:41:15 2023 -0800 Remove window usage from link terminalContrib Fixes #195804 commit 3fa7cc6 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 10:38:12 2023 -0800 Improve cls/clear SI behavior on Windows commit 8aa6274 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 10:37:49 2023 -0800 Invalidate commands in devMode commit c855616 Merge: 71a8b99 4f41508 Author: Ulugbek Abdullaev <ulugbekna@gmail.com> Date: Thu Nov 16 18:59:11 2023 +0100 Merge pull request #198461 from microsoft/ulugbekna/yawning-mastodon Replace `Date.now()` with UUID for `delegatingCommandId` commit bc42a84 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 09:57:40 2023 -0800 Adjust prompt start based on a likely single line prompt (pwsh default) commit 71a8b99 Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Thu Nov 16 18:35:17 2023 +0100 Fixes CI commit 917b056 Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Thu Nov 16 18:28:19 2023 +0100 Multi diff editor: Introduce view model commit 4f41508 Author: Ulugbek Abdullaev <ulugbekna@gmail.com> Date: Thu Nov 16 18:44:06 2023 +0100 extension host: use UUID for `delegatingCommandId` instead of `Date.now()` because when there are several extension hosts (created using "extensions.experimental.affinity") and they happen to be created at the same time, those IDs equal and command invocation may go to incorrect extension host commit 6b8bbf8 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 09:21:07 2023 -0800 Ensure end is after executed and prompt start is after end Part of #198278 commit 83e608a Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 09:19:52 2023 -0800 Add alternating colors to devmode decorations to help differentiate commit 4e7a877 Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Thu Nov 16 17:32:00 2023 +0100 Consider settings in multi diff editor commit 70b6f95 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 17:30:06 2023 +0100 aux window - scope editor service in title bar (#198450) commit 87e7f8b Author: João Moreno <joao.moreno@microsoft.com> Date: Thu Nov 16 17:29:35 2023 +0100 replace node-fetch with native fetch (#198408) * replace node-fetch with native fetch * fix dep version * handle terminated error from fetch * more error handling commit c520c85 Author: João Moreno <joao.moreno@microsoft.com> Date: Thu Nov 16 17:28:20 2023 +0100 have hidden prss setting (#198449) commit 2e4d75f Author: Benjamin Simmonds <44439583+benibenj@users.noreply.github.com> Date: Thu Nov 16 17:20:56 2023 +0100 remove setting (#198439) commit 1c39707 Author: Rob Lourens <roblourens@gmail.com> Date: Thu Nov 16 10:18:30 2023 -0600 Don't clear chat input on "new session" (#198447) commit 1cf3ec8 Author: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Date: Thu Nov 16 17:02:00 2023 +0100 turning off the editor gutter icon commit 7d4091a Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 16:42:24 2023 +0100 aux window :lipstick: (#198445) commit 6c8fd34 Author: Johannes Rieken <johannes.rieken@gmail.com> Date: Thu Nov 16 16:27:36 2023 +0100 Joh/young-catshark (#198416) * add save & discard-btns to inline new file experience, simplify response type because we don't really support workspace edit, fix size/height bug, fix positioning bug * fix preview mode, clean up events, fix workspace edit escape hatch * merge main, fix compile errors commit 20cd4e4 Author: Johannes Rieken <johannes.rieken@gmail.com> Date: Thu Nov 16 16:25:59 2023 +0100 fix #198423 (#198443) commit a50c647 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 15:59:00 2023 +0100 editors - include preferred name and description in tooltip if available (fix #198204) (#198441) commit 33244ee Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 06:37:59 2023 -0800 Use a single overview ruler indicator for command nav Fixes #198437 commit d6f9e21 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 15:30:07 2023 +0100 aux window :lipstick: (#198433) commit efe5bee Author: Alex Ross <alros@microsoft.com> Date: Thu Nov 16 15:28:43 2023 +0100 Fix small comment input when starting collapsed + editable (#198431) Fixes #197793 commit 6d0b5c4 Merge: 1010cae 14ced5d Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 06:26:57 2023 -0800 Merge pull request #198430 from microsoft/tyriar/config_helper Move term config helper into browser commit 1010cae Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Thu Nov 16 15:17:01 2023 +0100 SCM - add twistie for empty resource group and incoming/outgoing node (#198427) commit 14ced5d Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu Nov 16 06:11:12 2023 -0800 Move term config helper into browser commit c2c4439 Author: Simon Siefke <simon.siefke@gmail.com> Date: Thu Nov 16 14:49:48 2023 +0100 fix: memory leak in comments controller (#198237) commit 0d54424 Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Thu Nov 16 14:26:31 2023 +0100 Handle the case that env is undefined (in monaco-editor when building with parcel) commit a6469ca Author: Benjamin Simmonds <44439583+benibenj@users.noreply.github.com> Date: Thu Nov 16 14:27:18 2023 +0100 Refactor Configuration Migration Logic (#198414) * fix migration #198056 commit cfd5267 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 13:23:59 2023 +0100 aux window - fix watermark positioning (#198418) commit d79607b Author: João Moreno <joao.moreno@microsoft.com> Date: Thu Nov 16 13:09:58 2023 +0100 Add telemetry: 'update:error' (#198415) telemetry: 'update:error' commit 0cb29d6 Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Thu Nov 16 13:05:25 2023 +0100 SCM - fix issue with incoming/outgoing separator (#198413) commit 510f5c2 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 12:36:04 2023 +0100 Aux window - drag/drop puts new window on wrong display (fix #198397) (#198409) * Aux window - drag/drop puts new window on wrong display (fix #198397) * 💄 commit 28a7bc4 Author: Ole <ole@rehmsen.de> Date: Thu Nov 16 11:29:46 2023 +0100 Make xtermTerminal.test.ts hermetic. With this change, it also passes when run alone. Fixes #198401 commit 5b90c56 Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 11:25:57 2023 +0100 aux window - show empty group actions and hide tips (#198400) commit 6aa249d Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Thu Nov 16 10:45:13 2023 +0100 Git - fix incorrect check (#198396) commit cacd71f Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Thu Nov 16 09:12:02 2023 +0100 SCM - refactor history provider cache cleanup (#198378) * Initial implementation * Remove private property as it is not needed any more * Improve cache manipulation commit ab66bab Author: Benjamin Pasero <benjamin.pasero@microsoft.com> Date: Thu Nov 16 08:36:54 2023 +0100 aux window - support confirm on close (#198307) commit 7688a7c Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Thu Nov 16 08:18:41 2023 +0100 Engineering - update incoming/outgoing workspace settings (#198386) commit 0b111a0 Author: João Moreno <joao.moreno@microsoft.com> Date: Thu Nov 16 07:19:59 2023 +0100 Publish to new CDN (#198154) commit 444e737 Author: Rob Lourens <roblourens@gmail.com> Date: Wed Nov 15 18:27:32 2023 -0600 Fix label caps (#198379) Fix microsoft/vscode-copilot-release#552 commit 956bfb6 Author: Rob Lourens <roblourens@gmail.com> Date: Wed Nov 15 18:14:44 2023 -0600 Add "new session" to chat context menu (#198376) From discussion commit 36dee1f Merge: f5a048f 4d30cfe Author: Megan Rogge <merogge@microsoft.com> Date: Wed Nov 15 16:14:26 2023 -0800 Merge pull request #198375 from microsoft/merogge/bug2 focus terminal based on task focus option commit f5a048f Merge: d5b7d48 defffc1 Author: Peng Lyu <penn.lv@gmail.com> Date: Wed Nov 15 15:51:47 2023 -0800 Merge pull request #198276 from microsoft/rebornix/lonely-wildfowl notebook cell chat widget commit d5b7d48 Author: Connor Peet <connor@peet.io> Date: Wed Nov 15 15:35:21 2023 -0800 debug: bump table visualizer ext (#198374) commit 4f303bb Author: Matt Bierner <matb@microsoft.com> Date: Wed Nov 15 15:31:39 2023 -0800 Disable md paste file path in untitled notebooks (#198372) Fixes #194809 Since the notebook does not exist on disk yet, there's no way to write a relative path in it. Just disable the feature since there's nothing else we can reasonably do here commit 4d30cfe Author: Megan Rogge <merogge@microsoft.com> Date: Wed Nov 15 15:23:32 2023 -0800 Update .vscode/tasks.json commit 0f967b6 Author: meganrogge <megan.rogge@microsoft.com> Date: Wed Nov 15 15:22:16 2023 -0800 fix #197394 commit 9c47447 Author: meganrogge <megan.rogge@microsoft.com> Date: Wed Nov 15 15:12:17 2023 -0800 fix #198370 commit 39715d6 Merge: 11a6cf4 79f8821 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 15:08:44 2023 -0800 Merge pull request #198360 from microsoft/tyriar/195804_2 Replace window usage within terminal commit defffc1 Author: rebornix <penn.lv@gmail.com> Date: Wed Nov 15 15:08:38 2023 -0800 Update cell indicator offset commit 11a6cf4 Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Thu Nov 16 00:08:10 2023 +0100 SCM - refactor incoming/outgoing settings (#198368) commit 9a207df Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Thu Nov 16 00:07:09 2023 +0100 SCM - adjust statistics badge border when item is selected/focused (#198367) commit 881e54d Merge: 7f2da72 c3783ac Author: Megan Rogge <merogge@microsoft.com> Date: Wed Nov 15 14:36:42 2023 -0800 Merge pull request #198338 from microsoft/merogge/terminal-editor-focus tweak `when` for kill active terminal editor command commit 7f2da72 Merge: cbab473 d7b119f Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 14:21:38 2023 -0800 Merge pull request #198356 from microsoft/tyriar/198352 Fix sticky scroll positioning to avoid bg leaking through commit 79f8821 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 14:21:10 2023 -0800 Use any to avoid layer issue commit cbab473 Author: Matt Bierner <matb@microsoft.com> Date: Wed Nov 15 14:06:12 2023 -0800 Disable dragging of links in rendered markdown (#198362) These links don't work properly. Better to disable them for now instead of allowing invalid drags commit d98713b Author: Matt Bierner <matb@microsoft.com> Date: Wed Nov 15 14:02:55 2023 -0800 Always send `CodeActionTriggerKind` (#198364) Makes us always send this along instead of sometimes sending undefined commit b315102 Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Wed Nov 15 21:54:56 2023 +0100 Implements global vertical scrolling commit f404d11 Merge: 5fcda6b 35fbd62 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 14:00:32 2023 -0800 Merge pull request #198355 from microsoft/tyriar/198013_keybinding_hint Add command nav hint to sticky scroll hover commit 5fcda6b Author: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Date: Wed Nov 15 22:31:00 2023 +0100 SCM - improve statistics badge (#198353) commit e563d91 Author: Rob Lourens <roblourens@gmail.com> Date: Wed Nov 15 15:12:56 2023 -0600 Fix the size of the animated loading text so it doesn't push the chat toolbar around (#198354) commit 49a83ee Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 13:08:42 2023 -0800 Replace window usage within terminal Fixes #195804 commit d7b119f Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 12:49:40 2023 -0800 Fix sticky scroll positioning to avoid bg leaking through Fixes #198352 commit 35fbd62 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 12:46:08 2023 -0800 Add command nav hint to sticky scroll hover Fixes #198013 commit 8943ea4 Author: Matt Bierner <matb@microsoft.com> Date: Wed Nov 15 12:03:04 2023 -0800 Fix markdown code block styling (#198351) Fixes #198183 Remove extra background and also removes the extra divs inside of the code blocks as these were causing issues with styling (extra padding) commit 65b8f67 Merge: eca3d31 bff6047 Author: Megan Rogge <merogge@microsoft.com> Date: Wed Nov 15 11:19:28 2023 -0800 Merge pull request #198345 from microsoft/merogge/close-on-keypress add `AccessibleViewCloseOnKeyPress` setting, move editor help code to separate file commit eca3d31 Author: Logan Ramos <lramos15@gmail.com> Date: Wed Nov 15 12:11:50 2023 -0700 Fix regression in paste context menu (#198346) commit afe429c Author: rebornix <penn.lv@gmail.com> Date: Wed Nov 15 11:09:41 2023 -0800 Listen to inline and dismiss on cell properly commit 23fc07c Author: Rob Lourens <roblourens@gmail.com> Date: Wed Nov 15 13:07:14 2023 -0600 Simplify ChatModel more (#198344) * Simplify ChatModel further * Simplify ChatModel more * Remove helper * Clean up * Fix addCompleteRequest * Fix updateRepr commit bff6047 Author: meganrogge <megan.rogge@microsoft.com> Date: Wed Nov 15 10:44:20 2023 -0800 fix #197792 commit f26376f Author: Henning Dieterichs <hdieterichs@microsoft.com> Date: Wed Nov 15 18:42:55 2023 +0100 Removes unneeded monaco-editor-esm-bundle commit a0b5488 Author: Connor Peet <connor@peet.io> Date: Wed Nov 15 10:41:22 2023 -0800 eng: add assertHeap method for memory assertions (#198334) This adds an `assertHeap` function that can be used in tests. It takes a heap snapshot, and asserts the state of classes in memory. This works in Node and the Electron sandbox, but is a no-op in the browser. Snapshots are process asynchronously and will report failures at the end of the suite. This method should be used sparingly (e.g. once at the end of a suite to ensure nothing leaked before), as gathering a heap snapshot is fairly slow, at least until V8 11.5.130 (https://v8.dev/blog/speeding-up-v8-heap-snapshots). When used, the function will ensure the test has a minimum timeout duration of 20s to avoid immediate failures. It takes options containing a mapping of class names, and assertion functions to run on the number of retained instances of that class. For example: ```ts assertSnapshot({ classes: { ShouldNeverLeak: count => assert.strictEqual(count, 0), SomeSingleton: count => assert(count <= 1), } }); ``` Closes #191920 commit 8cac42e Merge: 9998f63 0edd8b4 Author: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed Nov 15 09:44:54 2023 -0800 Merge pull request #197099 from hamirmahal/feat/allow-keyboard-shortcut-creation-for-terminal-copy-commands feat: allow keyboard shortcut creation for terminal copy commands commit 0edd8b4 Author: meganrogge <megan.rogge@microsoft.com> Date: Wed Nov 15 09:29:40 2023 -0800 tweak name commit 1d592f0 Author: meganrogge <megan.rogge@microsoft.com> Date: Wed Nov 15 09:25:08 2023 -0800 rename command commit a50d469 Merge: 26f9389 9998f63 Author: Megan Rogge <merogge@microsoft.com> Date: Wed Nov 15 09:19:27 2023 -0800 Merge branch 'main' into feat/allow-keyboard-shortcut-creation-for-terminal-copy-commands commit c3783ac Author: meganrogge <megan.rogge@microsoft.com> Date: Wed Nov 15 09:16:50 2023 -0800 fix #188145 commit 2fd988f Author: rebornix <penn.lv@gmail.com> Date: Tue Nov 14 23:06:16 2023 -0800 early return for cancelled request commit a9954e0 Author: rebornix <penn.lv@gmail.com> Date: Tue Nov 14 23:04:23 2023 -0800 Handle code cell editor async ctor commit 77f41a2 Author: rebornix <penn.lv@gmail.com> Date: Tue Nov 14 22:45:28 2023 -0800 Update styles commit c9b730c Author: rebornix <penn.lv@gmail.com> Date: Tue Nov 14 22:06:55 2023 -0800 styling update commit 17f0e23 Author: rebornix <penn.lv@gmail.com> Date: Mon Nov 13 21:29:46 2023 -0800 part/controller/widget commit 57d450c Author: rebornix <penn.lv@gmail.com> Date: Mon Nov 13 21:18:05 2023 -0800 Support Insert Cell with Chat enabled commit ae8d58a Author: rebornix <penn.lv@gmail.com> Date: Mon Nov 13 21:13:41 2023 -0800 Extract insertNewCell function commit 055662f Author: rebornix <penn.lv@gmail.com> Date: Mon Nov 13 21:13:14 2023 -0800 reveal cell is async commit 1d150d7 Author: rebornix <penn.lv@gmail.com> Date: Mon Nov 13 19:58:51 2023 -0800 Extract strategy commit ecd4f38 Author: rebornix <penn.lv@gmail.com> Date: Mon Nov 13 19:35:17 2023 -0800 On cell chat commit 26f9389 Author: Hamir Mahal <hamirmahal@gmail.com> Date: Mon Nov 6 11:24:53 2023 -0800 feat: allow users to create new keyboard shortcuts This allows keyboard shortcuts for 1. copying the last command and 2. copying the last command **and** its output Previously, it was only possible for users to copy the last command's output, without copying the last command itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently we are manually hunting down memory leaks through Dev Tools. For some areas/components (e.g., notebook), this even needs to be done repeatedly. It would be helpful if we can capture the memory snapshots in CI and write some queries against the snapshot to analyze if there is any potential leaks.
A typical manual memory leak analysis for notebook
NotebookTextModelobject, there should be noneNotebookCellTextModelobject, there should be noneNotebookEditorobject, there should not be more than one (the editor group still holds a reference to the last editor)cc @jrieken @connor4312 @Tyriar
The text was updated successfully, but these errors were encountered: