-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aux window: move away from globals that need to be contextual #195888
Comments
window
, document
usageswindow
, document
and globals usages
window
, document
and globals usages
After discussion with Jo: maybe we could patch Pending investigation what happens when a window closes that has a timer associated. |
More on |
The remaining usages of |
@bpasero I fixed the $window usage in notebook now. |
With floating windows, there is not just one
window
ordocument
but one per window. Global use ofwindow
anddocument
should cause a ESLint warning and utilities should be provided as alternatives.Adoptions
$window
//cc @alexdima
The text was updated successfully, but these errors were encountered: