Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight terminal commands subtly when mousing over them #196634

Closed
Tyriar opened this issue Oct 25, 2023 · 4 comments · Fixed by #198219
Closed

Highlight terminal commands subtly when mousing over them #196634

Tyriar opened this issue Oct 25, 2023 · 4 comments · Fixed by #198219
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2023

Highlighting a block would give the user a hint when hovering the terminal that it knows a lot more than a regular terminal. For example this part could be slightly darker or lighter depending on the theme:

Image

@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Oct 25, 2023
@Tyriar Tyriar added this to the November 2023 milestone Oct 25, 2023
@Tyriar Tyriar self-assigned this Oct 25, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Oct 27, 2023

This needs xtermjs/xterm.js#4855 and probably another API that forces the decoration to render on non-null cells

@Tyriar
Copy link
Member Author

Tyriar commented Nov 12, 2023

Another idea is to extends the solid bar on the left when hovering, right clicking could bring up the command's SI menu

@Tyriar
Copy link
Member Author

Tyriar commented Nov 14, 2023

I got a basic version of this working and it looked out of place:

image

Instead of background color I tried the re-use the command navigation focus bar on the left and it felt too noisy, especially when you compare it to what the editor looks like when you hover it.

Prototype: #198219

I started a discussion with the team

Tyriar added a commit that referenced this issue Nov 17, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 18, 2023
Splizard pushed a commit to Splizard/vscode-mobile that referenced this issue Nov 21, 2023
Splizard pushed a commit to Splizard/vscode-mobile that referenced this issue Nov 21, 2023
@tocic
Copy link

tocic commented Dec 10, 2023

Thank you for this feature, very useful for me! Is it possible to adjust the color of this bar? I can't find a setting here.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants