Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The KeyboardEvent.getModifierState function can be undefined. #198308

Closed
samirzubi-db opened this issue Nov 15, 2023 · 6 comments
Closed

[Bug] The KeyboardEvent.getModifierState function can be undefined. #198308

samirzubi-db opened this issue Nov 15, 2023 · 6 comments
Assignees

Comments

@samirzubi-db
Copy link

samirzubi-db commented Nov 15, 2023

We have been encountering a type error TypeError: t.getModifierState is not a function

Steps to Reproduce:
Do not have a way to reproduce the issue but my hunch lies with a autofill event that does not have the getModifierState gets triggered. Noticed in monaco-editor library but the file associated with the issue is in this library.

@alexdima alexdima added this to the December 2023 milestone Dec 4, 2023
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2023
@jrieken
Copy link
Member

jrieken commented Dec 4, 2023

@samirzubi-db What browser do you use? According to https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/getModifierState#browser_compatibility this should be supported since a couple of years everywhere

@samirzubi-db
Copy link
Author

samirzubi-db commented Dec 4, 2023

We detected that one customer had this issue. I will see if I can find what browser produced it and update you on it. I could not reproduce it on any of the browsers I have Mac, Windows (Chrome, Firefox, Edge).

@alexdima
Copy link
Member

Closing since we could not reproduce.

@alexdima alexdima closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
@alexdima alexdima removed the bug Issue identified by VS Code Team member as probable bug label Jan 25, 2024
@justin-mellor
Copy link

@alexdima I have a reproduction for this issue in the monaco-editor
See microsoft/monaco-editor#4325
It occurs in Edge and Chrome.

@Lindahot
Copy link

Lindahot commented Jan 29, 2024 via email

@mivanyna
Copy link

mivanyna commented Feb 13, 2024

This can be reproduced easily

@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants