Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop file into markdown doesn't create link #209239

Closed
mjbvz opened this issue Apr 1, 2024 · 1 comment
Closed

Drop file into markdown doesn't create link #209239

mjbvz opened this issue Apr 1, 2024 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release markdown Markdown support issues verified Verification succeeded
Milestone
March 2024

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 1, 2024

Type: Bug

  1. Drop an image file from the VS Code explorer into a md file

Bug
No markdown image inserted, just the file name

VS Code version: Code - Insiders 1.88.0-insider (Universal) (d994aed, 2024-03-29T22:24:49.191Z)
OS version: Darwin arm64 23.4.0
Modes:

System Info
Item Value
CPUs Apple M2 Max (12 x 24)
GPU Status 2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software
Load (avg) 3, 3, 3
Memory (System) 64.00GB (0.53GB free)
Process Argv --crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda
Screen Reader no
VM 0%
@mjbvz mjbvz self-assigned this Apr 1, 2024
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Apr 1, 2024
@mjbvz mjbvz added this to the March 2024 milestone Apr 1, 2024
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 1, 2024
@mjbvz
Limit drop disablement to just http(s) uris
1c75f21 
For microsoft#209239
@mjbvz mjbvz mentioned this issue Apr 1, 2024
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Apr 1, 2024
@mjbvz
Limit drop bail out to just http(s) uris
0f0e8bf 
Fixes microsoft#209239

The previous check was too broad and caused us to bail when pasting `file` uris. The specific case this code was trying to work around was copy/pasting from the browser address bar, which should almost always be a http or https uri
@mjbvz mjbvz mentioned this issue Apr 1, 2024
Merged
@mjbvz mjbvz added the markdown Markdown support issues label Apr 1, 2024
mjbvz added a commit that referenced this issue Apr 1, 2024
@mjbvz
Limit drop disablement to just http(s) uris (#209240)
7d788e7 
For #209239
mjbvz added a commit that referenced this issue Apr 1, 2024
@mjbvz
Limit drop bail out to just http(s) uris (#209241)
f776fed 
Fixes #209239

The previous check was too broad and caused us to bail when pasting `file` uris. The specific case this code was trying to work around was copy/pasting from the browser address bar, which should almost always be a http or https uri
@deepak1556
Copy link
Collaborator

Closing for verification.

@rzhao271 rzhao271 added the verified Verification succeeded label Apr 2, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
March 2024
Development

No branches or pull requests
3 participants
@deepak1556 @rzhao271 @mjbvz