Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url handling for settings #212079

Closed
alexr00 opened this issue May 6, 2024 · 0 comments · Fixed by #219702
Closed

Add url handling for settings #212079

alexr00 opened this issue May 6, 2024 · 0 comments · Fixed by #219702
Assignees
@alexr00
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan release-notes Release notes issues
Milestone
July 2024

Comments

@alexr00
Copy link
Member

alexr00 commented May 6, 2024

With #60170, we have clickable links in the release notes for settings, but only when the release notes are in VS Code. It would be cool if these links also existed in the release notes in your browser, so you could click on them and open VS Code with the settings editor already set to the setting in question.
@alexr00 alexr00 added feature-request Request for new features or functionality release-notes Release notes issues labels May 6, 2024
@alexr00 alexr00 added this to the May 2024 milestone May 6, 2024
@alexr00 alexr00 self-assigned this May 6, 2024
@kieferrm kieferrm mentioned this issue May 6, 2024
Closed
52 tasks
@alexr00 alexr00 modified the milestones: May 2024, June 2024 May 27, 2024
@kieferrm kieferrm mentioned this issue Jun 12, 2024
Closed
50 tasks
@alexr00 alexr00 modified the milestones: June 2024, July 2024 Jun 25, 2024
alexr00 added a commit that referenced this issue Jul 2, 2024
@alexr00
Add url handling for settings and adopt in release notes
42738c4 
Fixes #212079
@alexr00 alexr00 mentioned this issue Jul 2, 2024
Merged
@kieferrm kieferrm mentioned this issue Jul 7, 2024
Closed
48 tasks
@alexr00 alexr00 closed this as completed in 3eb4e36 Jul 8, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders labels Jul 8, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 9, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@alexr00 @aaronchucarroll
Add url handling for settings and adopt in release notes (microsoft#2…
51ce580 
…19702)

* Add url handling for settings and adopt in release notes
Fixes microsoft#212079

* Update regex to use product service, fix test

* Incorporate feedback

* Check value of setting before passing to settings editor

* Fix test
@alexr00 alexr00 mentioned this issue Jul 22, 2024
Closed
3 tasks
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan release-notes Release notes issues
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Add url handling for settings and adopt in release notes microsoft/vscode
2 participants
@alexr00 @vscodenpa