Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for interactive.execute should be True #213858

Closed
anthonykim1 opened this issue May 29, 2024 · 0 comments · Fixed by #214161
Closed

Default value for interactive.execute should be True #213858

anthonykim1 opened this issue May 29, 2024 · 0 comments · Fixed by #214161
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders interactive-window on-testplan
Milestone

Comments

@anthonykim1
Copy link
Contributor

anthonykim1 commented May 29, 2024

With the new REPL from Python extension merged, user has to explicitly set interactiveWindow.executeWithShiftEnter: false in their settings.json in order to execute via Enter Keypress when using interactive Native REPL.
They won't have to manually change this setting once the default value for interactiveWindow.execute is changed to True in core.

In order to provide closer experience to the traditional Python interactive interpreter experience (pressing enter would smartly execute or wait for more complete code), we should change the default value for interative.execute to be True.

Users who explicitly set their executeWithShiftEnter are respected at the current moment in a way that their settings are respected when using Python extension's native REPL to shift+enter or enter.

Related: #212051 microsoft/vscode-jupyter#15714

@anthonykim1 anthonykim1 added this to the June 2024 milestone May 29, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 3, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders interactive-window on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants