Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: IW execution hint #216852

Closed
2 tasks done
amunger opened this issue Jun 21, 2024 · 0 comments
Closed
2 tasks done

test: IW execution hint #216852

amunger opened this issue Jun 21, 2024 · 0 comments

Comments

@amunger
Copy link
Contributor

amunger commented Jun 21, 2024

Refs: #213858

Complexity: 3

Create Issue


Description

The default keybinding for executing the input of the interactive window has been switched from shift+enter to just enter to match up better with typical REPL behavior. To minimize the impact of this behavior, we have increased the visibility of the execution hint in the input box and also added a button to quickly configure that setting.

  • The gear icon toolbar is planned to be a temporary addition for this migration.
  • A setting is ideal for configuring this behavior since both python and core contribute a keybinding, and both respect this setting

Pre-requisites - If you don't have python set up to run notebooks

  1. Install both jupyter and python pre-release extensions
  2. ensure python is installed on your machine
  3. open a workspace where you will be running tests for this TPI
  4. Create: new jupyter notebook and run print(1) in a cell.
    a. If the cell runs successfully, you're already set up, otherwise...
  5. The kernel picker should open, select "Python Environments..." -> "Create Python Environment..." -> select venv or conda, and whichever version you'd like.

A virtual environment should get created in your workspace with all necessary packages installed, and the cell should run successfully.

Test steps

  1. run the command Jupyter: Create Interactive Window
  2. note the execution hint in the input box, and use the stated keyboard shortcut to execute a command, e.g. print(1)
  3. when the input is empty, click the gear to open the related settings, and swap the setting to change the keybinding
  4. ensure that the hint is updated and that the new keyboard shortcut works to execute
@vscodenpa vscodenpa added this to the June 2024 milestone Jun 21, 2024
@deepak1556 deepak1556 removed their assignment Jun 25, 2024
@bamurtaugh bamurtaugh removed their assignment Jun 25, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants