Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal ligatures can have the wrong background color when typed out #233005

Closed
Tyriar opened this issue Nov 4, 2024 · 1 comment · Fixed by #233024
Closed

Terminal ligatures can have the wrong background color when typed out #233005

Tyriar opened this issue Nov 4, 2024 · 1 comment · Fixed by #233024
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
November 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 4, 2024

Follow up on #34103

Repro:

  1. Enable terminal ligatures
  2. Set a font with ligatures
  3. Type =>, ==>, etc., 🐛 it looks like the cursor gets stuck at the end of the ligature

Image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 4, 2024
@Tyriar Tyriar added this to the November 2024 milestone Nov 4, 2024
@Tyriar Tyriar self-assigned this Nov 4, 2024
@Tyriar Tyriar mentioned this issue Nov 4, 2024
Open
@Tyriar
Copy link
Member Author

Tyriar commented Nov 4, 2024

Upstream: xtermjs/xterm.js#5205

@Tyriar Tyriar added the upstream-issue-linked This is an upstream issue that has been reported upstream label Nov 4, 2024
@Tyriar Tyriar mentioned this issue Nov 4, 2024
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 4, 2024
@Tyriar
Ensure last ligature cell is updated
129cbd8 
Fixes xtermjs#5207
Fixes xtermjs#3288
Fixes xtermjs#5206
Part of microsoft/vscode#233005
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 4, 2024
@Tyriar
Ensure last ligature cell is updated
7fab293 
Fixes xtermjs#3288
Fixes xtermjs#5206
Part of microsoft/vscode#233005
@Tyriar Tyriar mentioned this issue Nov 4, 2024
Merged
Tyriar added a commit that referenced this issue Nov 4, 2024
@Tyriar
5.6.0-beta.70
77cfcdd 
Fixes #233005
@Tyriar Tyriar mentioned this issue Nov 4, 2024
Merged
@Tyriar Tyriar closed this as completed in 3751bec Nov 4, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

xterm@5.6.0-beta.70 microsoft/vscode
1 participant
@Tyriar