Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diff3 for showing diff #23926

Closed
simonech opened this issue Apr 5, 2017 · 6 comments
Closed

Use diff3 for showing diff #23926

simonech opened this issue Apr 5, 2017 · 6 comments
Assignees
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@simonech
Copy link

simonech commented Apr 5, 2017

How can I set VSCode to use diff3 as merge/diff algorithm instead of normal diff?

If I show diff in VSCode I have

screen shot 2017-04-05 at 11 26 22

while if I do it from the command line after having configured diff3 as merge tool git config --global merge.conflictstyle diff3 and having specified that I want *.cs -text diff=csharp I get:

image

Is it possible to have the same "semantic" diff behaviour also in VSCode?

@simonech simonech changed the title Use Use diff3 for showing diff Apr 5, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Apr 5, 2017

In VSCode's diff editor, you can switch to 'inline' view by clicking on the '...' in the top right corner of the editor and then choosing 'Switch to Inline View'. Does that address your request?

screen shot 2017-04-05 at 8 23 46 am

@chrmarti chrmarti added the info-needed Issue requires more information from poster label Apr 5, 2017
@simonech
Copy link
Author

simonech commented Apr 5, 2017

Nope...
I meant that VS Code shows the following as added

        }

        private string SayHello()
        {
            return "Hello";

Using diff3 specifying the csharp language you get

        private string SayHello()
        {
            return "Hello";
        }

@rebornix rebornix assigned joaomoreno and unassigned rebornix Apr 5, 2017
@joaomoreno
Copy link
Member

I take this as a feature request for our diff algorithm.

@joaomoreno joaomoreno added diff-editor Diff editor issues feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Apr 6, 2017
@joaomoreno joaomoreno assigned alexdima and unassigned joaomoreno Apr 6, 2017
@simonech
Copy link
Author

simonech commented Apr 6, 2017

So, VSCode is not just getting the diff from git, but it's aoolying its own diff algorithm. So that's why if I change diff in GIT I don't get it in the git diff view in VS Code.
Makes sense.

Well... would be a good new feature :) Thx for reviewing the request.

@alexdima alexdima added this to the Backlog milestone Apr 12, 2017
@alexdima alexdima removed their assignment Apr 12, 2017
@alexdima
Copy link
Member

alexdima commented Jul 4, 2017

I think this is covered by c8df698 (for #30087)

@alexdima alexdima closed this as completed Jul 4, 2017
@alexdima alexdima self-assigned this Jul 4, 2017
@alexdima alexdima modified the milestones: July 2017, Backlog Jul 4, 2017
@simonech
Copy link
Author

simonech commented Jul 4, 2017

Yeah, it indeed looks like it might fix the issue.
I'll test again when the July version gets released.
thx

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

6 participants