Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make diffs prettier #30087

Closed
alexdima opened this issue Jul 4, 2017 · 0 comments
Closed

Make diffs prettier #30087

alexdima opened this issue Jul 4, 2017 · 0 comments
Assignees
@alexdima
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality on-testplan
Milestone
July 2017

Comments

@alexdima
Copy link
Member

alexdima commented Jul 4, 2017 •
edited
Loading

The diff editor is technically correct (LCS et al), but not very pretty. It would be nice if there were some post-processing to make it nicer.

1. Adjacent diffs that could be merged

a.txt
b.txt

Actual:

screen shot 2017-07-04 at 13 03 40

Expected:

screen shot 2017-07-04 at 15 05 42

2. Give preference to empty lines as diff boundaries

a3.txt
b3.txt

Actual:

screen shot 2017-07-04 at 15 02 41

Expected:

screen shot 2017-07-04 at 16 03 34
@alexdima alexdima added the feature-request Request for new features or functionality label Jul 4, 2017
@alexdima alexdima added this to the July 2017 milestone Jul 4, 2017
@alexdima alexdima self-assigned this Jul 4, 2017
@alexdima alexdima added the diff-editor Diff editor issues label Jul 4, 2017
alexdima added a commit that referenced this issue Jul 4, 2017
@alexdima
prettier diff (#30087)
a2c47ca
alexdima added a commit that referenced this issue Jul 4, 2017
@alexdima
Shift diff up to get to boundaries (#30087)
c8df698
This was referenced Jul 4, 2017
Closed
Closed
@alexdima alexdima changed the title Make the diff more pretty Make diffs prettier Jul 4, 2017
@alexdima alexdima mentioned this issue Jul 4, 2017
Closed
@alexdima alexdima closed this as completed Jul 5, 2017
@kieferrm kieferrm mentioned this issue Jul 7, 2017
Closed
39 tasks
@alexdima alexdima mentioned this issue Jul 7, 2017
Closed
1 task
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
diff-editor Diff editor issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
2 participants
@weinand @alexdima