Add a default keybooard shortcut for toggling the integrated terminal

[giefferre]

The keyboard shortcut for the integrated terminal is disabled by default, and now users need to manually re-enable it creating a key binding.

• VSCode Version: 1.11.0 (1.11.0) 2017-04-05T20:49:18.310Z
• OS Version: macOS 10.12.4 (16E195)

Steps to Reproduce:

1. Open VSCode
2. Press ^ + \ (or correspective keys according to the macOS keyboard shortcuts map)

[mrailton]

It appears that the cause is actually VSCode reading the kaymapping wrong. When I went to remap the function it was showing as ctrl + ` which is what it always has been, however when I attempted to update this and used that key combo it showed up as ctrl + § instead.

I've confirmed the mapping on my mac is correct for the keyboard that I'm using.

[giefferre]

In my case the binding was not present at all (anymore) and I eventually had to manually set it again.

[chrmarti]

Which keyboard layout are you using?

[mrailton]

The irish layout for apple keyboard on macOS 10.12.4

…

On Thu, Apr 6, 2017 at 7:26 PM, chrmarti ***@***.***> wrote: Which keyboard layout are you using? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24086 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF1wJdxljquWqZIAVMAhPL4M3-xw2_8xks5rtS5cgaJpZM4M1yj4> .

[alexdima]

@railto What do you mean VS Code reads the keymapping wrong? Here is an in-depth explanation of what we are doing -- https://github.com/Microsoft/vscode/wiki/Keybindings
We do not ship with keyboard layout specific default keybindings, e.g. we don't ship with keybindings optimized for the Irish keyboard layout. It is therefore possible that we lack some default keybindings or that they are unfortunate/badly placed. This can be upvoted in #1240

@giefferre That PDF is valid for a US standard English layout. For your current keyboard layout, the best way to find out default/your current keyboard shortcuts is to use the F1 list or Preferences > Keyboard Shortcuts.

Please let me know if you suspect there's anything else going wrong.

[jsynowiec]

Related to #23896

For me upgrading to 1.11.1 disables the ⌃+` shortcut that should be assigned to Toggle Terminal command. Executing this command from the Command Palette works as supposed.

VS Code version: 1.11.1 (1.11.1)
OS: macOS: 10.12.4

Everything works fine in 1.10.2.

[giefferre]

@alexandrudima this is what appears to be the default keybindings for the integrated terminal.

As @jsynowiec points out, it worked in 1.10.2 but stopped working in version 1.11.1.
Of course, when I run the 'toggle terminal' command from the Command Palette it works as expected.

As you can see I use the italian layout.

[jsynowiec]

In #24186 @lordchancellor pointed out that ` is switched with § on Mac so this might indicate a problem with keymapping?

[jkzing]

Same issue happen to me. I tried to set Toggle Integrated Terminal keymap shortcut to
ctrl + `

shift + `

alt + ` .

And all of them are worked as expect only excepted cmd + `.

Is it because of that cmd + ` is a reserved keybinding under MacOS? It is used to toggle opened windows of an App.

[intellix]

I was using: ctrl + ` previously with my Apple British Keyboard and it stopped working in the latest version.

The ` and § keys are mixed up as I see when re-binding that shortcut. Here's an example of a British layout :)

[mrailton]

@alexandrudima, the reply from @intellix explains exactly the issue I was trying to explain.

[alexdima]

Thank you all!

It is difficult to juggle so many different keyboard layouts in a single issue, here is what I suggest we do:

@giefferre OP
You appear to be using an Italian keyboard layout. From https://support.apple.com/en-ca/HT201794 I will assume it looks like this:

From the picture it appears that there is no way to produce ` on an Italian keyboard layout. That's why the terminal is not bound out of the box under the Italian keyboard layout. You can upvote that we ship with keyboard layout specific default keybindings in #1240

---

@jsynowiec @intellix @railto It appears you are using the British keyboard layout and we have some issue with [Backslash] and [IntlBackslash] where they are somehow swapped from a label point of view. Let's track in #24153 which clearly states it is about the British keyboard layout.

---

@jkzing It appears you cannot bind cmd + ` due to the OS eating up that keypress. I am sorry, if the keypress doesn't reach us, there is nothing we can do.

[giefferre]

Thanks @alexandrudima for your feedback.

The keyboard layout you posted is the right one, I used to toggle the integrated terminal using the CTRL+> < keys.

Upvoted the bug you linked.