Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension Names in Extension Browser Should Display an ... For Long Names #24240

Closed
mjbvz opened this issue Apr 7, 2017 · 4 comments
Closed

Extension Names in Extension Browser Should Display an ... For Long Names #24240

mjbvz opened this issue Apr 7, 2017 · 4 comments
Assignees
@joaomoreno @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions ux User experience issues verified Verification succeeded
Milestone
April 2017

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 7, 2017 •
edited
Loading

screen shot 2017-04-07 at 9 46 25 am

  1. Search for angular in the extension explorer

Bug
Note that extension names that are too long have a hard cutoff

Suggested Fix
Add a ... overflow to the name, similar to the extension description
@RishabhKothaari
Copy link
Contributor

@mjbvz I would like to contribute here. As the names of the extensions are under a flex box we should force the ... on its children, as text-overflow applies to block elements.

.extensions-viewlet>.extensions .extension>.details>.header-container>.header {
min-width: 0;
} 
.....
.extensions-viewlet>.extensions .extension>.details>.header-container>.header>.name{
text-overflow: ellipsis;
white-space: nowrap;
overflow: hidden;
}

fixes the issue.
Can I submit a PR here?

@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 7, 2017 •
edited
Loading

@RISHII7 Sure, a PR would be great. You may want to take a look at #24242 for this as well since that problem is somewhat related to this one

I believe @joaomoreno or @sandy081 should be able to review any PRs here and provide help on this issue

RishabhKothaari added a commit to RishabhKothaari/vscode that referenced this issue Apr 9, 2017
@RishabhKothaari
Merge pull request #1 from rishii7/microsoft#24240---Extension-Names-…
c394278 
…in-Extension-Browser-Should-Display-an--.-For-Long-Names-

Adds ... to long extension names.
@RishabhKothaari
Copy link
Contributor

#24371

@joaomoreno joaomoreno added this to the April 2017 milestone Apr 10, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions ux User experience issues labels Apr 10, 2017
@joaomoreno
Copy link
Member

Fixed by #24371, thanks @RISHII7 !

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
5 participants
@joaomoreno @RishabhKothaari @sandy081 @mjbvz @ramya-rao-a