Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick commands fuzzy search doesn't work for text in brackets #27636

Closed
Tyriar opened this issue May 30, 2017 · 4 comments · Fixed by #70868
Closed

Quick commands fuzzy search doesn't work for text in brackets #27636

Tyriar opened this issue May 30, 2017 · 4 comments · Fixed by #70868
Assignees
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 30, 2017

  • VSCode Version: Code - Insiders 1.13.0-insider (c2a17a7, 2017-05-30T05:12:15.312Z)
  • OS Version: Linux x64 4.10.0-21-generic
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.9.3
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.3.0
theme-sapphire Tyriar 0.2.1
vscode-svgviewer cssho 1.4.1
tslint eg2 0.15.0
git-project-manager felipecaputo 1.3.2
md-navigate jrieken 0.0.1
vscode-scss mrmlnc 0.6.2
seti-icons qinjia 0.1.3

#27316

fyi @ramya-rao-a

image

image

@jrieken jrieken assigned bpasero and unassigned jrieken May 31, 2017
@jrieken
Copy link
Member

jrieken commented May 31, 2017

The command palette doesn't use the new fuzzyScore-logic. It maybe should tho

@bpasero
Copy link
Member

bpasero commented May 31, 2017

Welcome to #27317

@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues workbench labels May 31, 2017
@bpasero bpasero removed their assignment May 31, 2017
@bpasero bpasero changed the title Quick pick fuzzy search doesn't work for text in brackets Quick commands fuzzy search doesn't work for text in brackets Sep 29, 2017
@bpasero bpasero removed the workbench label Nov 14, 2017
@alextegelid
Copy link

alextegelid commented Nov 13, 2018

I've noticed that it does in fact match characters inside parentheses, but won't match them if they're right next to the parentheses.

In my example GIF below you can see the following:

  1. Misses to match completely, due to the inc being next to the parentheses
  2. Matches if I actually type the parentheses
  3. Matches if I type words inside the parentheses but aren't next to them

screen recording 2018-11-13 at 04 23 pm

EDIT (2018-11-12):
It matches if all of the the characters in inside the parentheses:
image

However it won't match if i search two different parts of the text inside:
image

@jrieken
Copy link
Member

jrieken commented Mar 26, 2019

Thanks you @roblourens

@vscodebot vscodebot bot locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
5 participants