Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet: Select prev item gets stuck in comment blocks #27763

Closed
ramya-rao-a opened this issue May 31, 2017 · 1 comment
Closed

Emmet: Select prev item gets stuck in comment blocks #27763

ramya-rao-a opened this issue May 31, 2017 · 1 comment
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
June 2017

Comments

@ramya-rao-a
Copy link
Contributor

Testing #27316

  • Create a HTML file with multiple tags
  • Comment one of the tags
  • Keep cursor anywhere after the commented tag.
  • Use Emmet: Select prev Item to navigate through the tags and attributes

Observe that once you reach the commented tag, select prev doesnt work anymore.

Ideally we should skip commented tags.
Note: In css files, the commented parts do get skipped
@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues labels May 31, 2017
@ramya-rao-a ramya-rao-a self-assigned this May 31, 2017
@ramya-rao-a ramya-rao-a modified the milestones: May 2017, June 2017 May 31, 2017
@roblourens
Copy link
Member

Not sure whether to open a new issue or reopen this.

  • Open an html file
  • Comment out a tag
  • Use 'next item' and 'prev item' - it works as described, at first
  • After doing that a few times, it just stops working and 'next item' and 'prev item' have no effect. No errors in devtools

jun-28-2017 14-54-08

@roblourens roblourens reopened this Jun 28, 2017
ramya-rao-a added a commit that referenced this issue Jun 28, 2017
@ramya-rao-a
Fix infinite loop when node doesnt have non comment children. #27763
280ea0b
@sandy081 sandy081 added the verified Verification succeeded label Jun 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@roblourens @sandy081 @ramya-rao-a