Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When encountering errors, identify the extension they came from #32766

Closed
jrieken opened this issue Aug 18, 2017 · 2 comments
Closed

When encountering errors, identify the extension they came from #32766

jrieken opened this issue Aug 18, 2017 · 2 comments
Assignees
@jrieken
Labels
engineering VS Code - Build / issue tracking / etc. extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Milestone
August 2017

Comments

@jrieken
Copy link
Member

jrieken commented Aug 18, 2017

It's beneficial to know what extension threw what (caught/uncaught) error.
@jrieken jrieken self-assigned this Aug 18, 2017
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Aug 18, 2017
@jrieken jrieken added this to the August 2017 milestone Aug 18, 2017
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Aug 18, 2017
jrieken added a commit that referenced this issue Aug 18, 2017
@jrieken
don't log errors twice, #32766
d30567b
jrieken added a commit that referenced this issue Aug 18, 2017
@jrieken
prefix stack with extension id, #32766
69c9ede
jrieken added a commit that referenced this issue Aug 18, 2017
@jrieken
properly spec error data, #32766
dc69d8b
jrieken added a commit that referenced this issue Aug 18, 2017
@jrieken
send extension id to main thread and decide there how to show errors, #…
bfdff94 
…32766
@jrieken
Copy link
Member Author

jrieken commented Aug 18, 2017

When an error can be traced back to an extension we now send that information to the main side. The current "UX" is to prefix the error message with the extension identifier. More elaborated ideas are a decoration for collected errors in the extension viewlet, popup messages etc

screen shot 2017-08-18 at 18 04 16

@kieferrm kieferrm mentioned this issue Aug 21, 2017
Closed
53 tasks
@jrieken
Copy link
Member Author

jrieken commented Aug 21, 2017

Closing as we finished the data collection and now print rich information to the console. The next will be a new UI to collect runtime status of extensions

@jrieken jrieken closed this as completed Aug 21, 2017
@jrieken jrieken mentioned this issue Aug 24, 2017
Closed
@jrieken jrieken added the feature-request Request for new features or functionality label Aug 28, 2017
@jrieken jrieken mentioned this issue Aug 28, 2017
Closed
1 task
@jrieken jrieken added the release-notes Release notes issues label Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc. extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
2 participants
@jrieken @weinand