Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Inline Color Decorator & Color Picker performance fix #33295

Closed
1 task done
rebornix opened this issue Aug 28, 2017 · 1 comment
Closed
1 task done

Test: Inline Color Decorator & Color Picker performance fix #33295

rebornix opened this issue Aug 28, 2017 · 1 comment

Comments

@rebornix
Copy link
Member

rebornix commented Aug 28, 2017

Test for #32295

Complexity: 2

  • Color decorator rendering is moved to the core, we deprecated old extensions settings [css/less/sass/json].colorDecorators.enable and use language-aware editor.colorDecorators. Please verify that ppl can still use[css/less/sass/json].colorDecorators.enable: false to disable this feature and the new setting can do so as well.
  • Color decorator will be changed only when users select one color in Color Picker, which happens when mouse up, instead of every mouse movement.
  • Mouse down then move in Color Picker body should not make changes to the document. A simple extension can verify
    vscode.workspace.onDidChangeTextDocument( () => {
        console.log('content change');
    });
    
@vscodebot vscodebot bot added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Aug 28, 2017
@rebornix rebornix added testplan-item and removed css-less-scss Issues and items concerning CSS,Less,SCSS styling labels Aug 28, 2017
@rebornix rebornix added this to the August 2017 milestone Aug 28, 2017
@rebornix rebornix changed the title Test: Inline Color Decorator Test: Inline Color Decorator & Color Picker performance fix Aug 28, 2017
@alexdima alexdima removed their assignment Aug 29, 2017
@alexdima
Copy link
Member

Nice! ❤️

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants