Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Picker: Integrate inline color boxes #32295

Closed
joaomoreno opened this issue Aug 11, 2017 · 1 comment · Fixed by #32864
Closed

Color Picker: Integrate inline color boxes #32295

joaomoreno opened this issue Aug 11, 2017 · 1 comment · Fixed by #32864
Assignees
Labels
editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality
Milestone

Comments

@joaomoreno
Copy link
Member

Currently, languages are forced to create decorations in order to have those inline color boxes.

With the new color API, the core should be doing this for them.

@joaomoreno joaomoreno added editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality labels Aug 11, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Aug 11, 2017
@kobenauf
Copy link

kobenauf commented Aug 16, 2017

I agree. For example doing a project with material-ui, the style is in the javascript:

const styleSheet = createStyleSheet({
  App: {
    backgroundColor: '#F0E1D2',
    height: '100%'
  }
})

It would be very helpful to have some way of invoking the color picker for backgroundColor above.

@rebornix rebornix self-assigned this Aug 16, 2017
rebornix added a commit to rebornix/vscode that referenced this issue Aug 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants