Extra indentation of def when prefixed with "private"

[faustinoaq]

• VSCode Version: 1.15.0
• OS Version: Manjaro KDE Gellivara

Steps to Reproduce:

1. Open a ruby file.
2. Ensure autoIndent is enabled.
3. Write some function with indentation (by example, inside a class), then try to write end keyword

Reproduces without extensions: Yes

This happen by default in vscode, but other extensions like vscode-ruby and vscode-crystal-lang also have this issue:

• Extra indentation of def when prefixed with "private" crystal-lang-tools/vscode-crystal-lang#18
• Extra indentation of def when prefixed with "private" rubyide/vscode-ruby#203

[alexdima]

The root cause for this lies within the indentation rules defined for ruby at

https://github.com/Microsoft/vscode/blob/128a4e3640c5375f7b0bc1cfd37f626481b1386f/extensions/ruby/language-configuration.json#L25

I am not really sure how these should be changed to address the problem.

[faustinoaq]

Hi @rebornix @alexandrudima I did some indentation rules by myself:

I created it for Crystal but is almost the same for Elixir, Ruby, Julia and other similar languages. In fact, currently I'm using Ruby indentation rules for Crystal

indentationRules: {
    // /^[^#]*(
    //       ((
    //         ((if|elsif|lib|fun|module|struct|class|def|macro|do|rescue)\s)|
    //         (end\.)
    //       ).*)|
    //       ((begin|else|ensure|do|rescue)\b)
    //     )
    // $/
    increaseIndentPattern: /^[^#]*(((((if|elsif|lib|fun|module|struct|class|def|macro|do|rescue)\s)|(end\.)).*)|((begin|else|ensure|do|rescue)\b))$/,
    // /^\s*(
    //        ((rescue|ensure|else)\b)|
    //        (elsif\s.*)|
    //        (end(\..*|\b))
    //      )
    // $/
    decreaseIndentPattern: /^\s*(((rescue|ensure|else)\b)|(elsif\s.*)|(end(\..*|\b)))$/
}

It's working a quite well now, but case statement has a new problem with end keyword.

[faustinoaq]

Oh, good news @juicemia did a fix for vscode-ruby here 👉 rubyide/vscode-ruby#206

it was easier than I thought 😅

[alexdima]

Thank you @faustinoaq