Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expore improvements to minimap rendering performance #34170

Closed
Tyriar opened this issue Sep 11, 2017 · 3 comments
Closed

Expore improvements to minimap rendering performance #34170

Tyriar opened this issue Sep 11, 2017 · 3 comments
Assignees
Labels
debt Code quality issues editor-minimap Code/Text minimap widget issues *out-of-scope Posted issue is not in scope of VS Code perf
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2017

Currently we use putImageData to redraw the entire minimap each frame, we should explore keeping the source of truth of the image in the canvas and printing diffs to minimize the amount of rendering.

@Tyriar Tyriar added the perf label Sep 11, 2017
@Tyriar Tyriar added this to the September 2017 milestone Sep 11, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Sep 11, 2017

Not sure if there will be time for this in September (it's on the iteration plan though).

@Tyriar Tyriar added the editor-minimap Code/Text minimap widget issues label Sep 11, 2017
@alexdima
Copy link
Member

I have pushed an optimization where the dirtyY and dirtyHeight arguments of putImageData are exercised to reduce in many cases how much painting is done.

@Tyriar I leave it up to you to explore further optimizations.

@alexdima alexdima removed their assignment Sep 21, 2017
@Tyriar Tyriar modified the milestones: September 2017, Backlog Sep 26, 2017
@Tyriar Tyriar added the debt Code quality issues label Jan 2, 2018
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Sep 12, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 12, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues editor-minimap Code/Text minimap widget issues *out-of-scope Posted issue is not in scope of VS Code perf
Projects
None yet
Development

No branches or pull requests

3 participants