Undo stack lost at random times.

[tacho87]

After 0.10.9 vscode does not preserve the undo/redo stack. Sometimes it preserves for 5 to 10 items. It was not behaving like this before upgrading.

[joaomoreno]

@tacho87 Are you using OS X? Seems to be a duplicate of #3071. Related to #2829.

[alexdima]

@tacho87 Can you please share some reproducible steps?

[tacho87]

Yes I am using OSX, vscode Version 0.10.9 (0.10.9).
I tried to reproduce it. It seems to happen when I change from vscode to the browser and go back on JSX files mostly. Unfortunately , I do not have any steps or scenarios to reproduce it.

It just feels like it is refreshing the redo/undo stack when something happens internally when using JSX files.

[alexdima]

@tacho87 Is it possible that the files are changed on disk outside of VSCode? When a file changes on disk, we reload the file and drop the undo stack.

[tacho87]

I usually work on a share drive for backup purposes with git on it. Could that be the issue? I also experienced it today on a plain html/js file on my desktop. Seems to happen specially when I debug the js on chrome.

[alexdima]

@tacho87 We drop the undo stack when the file is edited on disk outside of VSCode. If a file is merely touched (but has the same content), we don't drop the undo stack. Are you editing the files through the Chrome debugger?

[joaomoreno]

@alexandrudima This could be a duplicate of #2908, if that question is answered positively.

[alexdima]

Most likely it is #2908

[warmhug]

On Mac, vs code's version of 1.3.1 also reproduce it

[bpasero]

This is #10932

[StefanPatatu]

I can confirm the bug still exists as of v1.4.0. The bug mostly manifests after I save a file (work on file, CTRL+S, webpack rebuilds, check browser, see everything is broken, realize I have a typo or something, ALT+TAB, then CTRL+Z no longer works). It also manifests randomly sometimes, but especially after CTRL+S-ing.

[bpasero]

@StefanPatatu what about Code 1.5 where we landed a fix?