Indenting multiple lines using Tab fails

[SamVerschueren]

I wanted to indent multiple lines at once but it failed. This is how it looks like when I select some lines and press Tab. Sometimes it works though, like when creating an untitled file in split screen.

Quite important bug @egamma @jrieken @bpasero

[bpasero]

@alexandrudima fyi

[philipgiuliani]

Same here! Cant work with it currently! It also intents completly wrong when i create a newline. (With a tab instead of spaces also...)

[SamVerschueren]

It also intents completly wrong when i create a newline. (With a tab instead of spaces also...)

That's something else and was introduced in the previous version as well. If editor.insertSpaces is set to auto it detects the indentation used by the opened file. But if you create a new file, it can't detect the indentation type so it uses spaces instead. Some issues regarding this have been raised already and should be discussed over there. Here it is: #1747

[rhires]

This looks like Mac OS behavior for the select before the editor knows that the select requires different behavior. It's just not catching that first select. Once the file is in the working files section then the editor has it in memory...this is me speculating, though, and watching what is happening.

[philipgiuliani]

Can somebody provide a link for VSCode 0.10.6? Its impossible to work on HTML with this Version. Hope to have it fixed soon.

@SamVerschueren
What i mean is the following. (Extension .jsx, file is not empty, it has 70 lines)
This behaviour was definetly not present before.

Steps to reproduce:

1. .jsx file (maybe also other ones)
2. Indent somewhere in a function, move the cursor to another line and save the file (be sure to have "remove leading whitespace" option enabled)
3. Go back to that line and press TAB.

[SamVerschueren]

@philipgiuliani Ok, that's definitely something else. Create a new issue for that one if you don't mind as it's not the same as this one and then they can separately being tracked by the team.

[philipgiuliani]

@SamVerschueren Thank you! Done in the following issue #2845.

[bpasero]

Previous releases are at https://github.com/Microsoft/vscode/wiki/Previous-Releases

[nchammas]

Having a similar issue with SQL files if I highlight some lines and try to indent them with tab.

This one is strange because, in addition to killing all the text, Command + Z refuses to undo the action!

If I manually indent the first line with 4 spaces and highlight the rest, hitting tab works as expected.

[alexdima]

@SamVerschueren @philipgiuliani @nchammas I am sorry, this looks horrible.

I cannot reproduce on a vanilla (no extensions) 0.10.8 on Windows.

I will try shortly on the mac

[SamVerschueren]

Indeed, might be related to Mac.

[alexdima]

@SamVerschueren Do you have any extensions installed that might hijack the tab key? i.e. just to be sure the built-in command executes, can you please add the following to the end of your keybindings.json:

{ "key": "tab", "command": "tab", "when": "editorTextFocus && !editorTabMovesFocus" }

[SamVerschueren]

Added that but still the same behaviour.

Switched to the insider build and removed all the extensions I had installed over there (just to make sure) but still the same.

[alexdima]

I still cannot reproduce. Can you think of anything else I might be doing differently? Do you have other settings for VSCode or maybe a different keyboard layout, etc...

Here I am trying on a mac:

All I do is select some text, press Tab a few times and undo (Cmd+Z)

I have just downloaded 0.10.8 from the website on a new mac install:

@weinand @joaomoreno Can you please also try to reproduce this?

[SamVerschueren]

This is odd.

I installed a new fresh version of the latest insider build. Removed my Application Support/Code - Insiders directory to make sure I don't have any setting specified. Still the same behaviour.

I have a U.S. keyboard layout.

---

@alexandrudima In your second example (the untitled file), can you type your text (as it is now), save it as test.txt or something and try it again?

[alexdima]

Ok, here I am trying again with an untitled file that then I save on top of an existing file.

Do you maybe press Tab while in the OS menus? Do you maybe have any errors in the console (F1 > Toggle Developer Tools)? Does this repro when pressing Cmd+] which is an alternative binding for indent lines?

Here is the OSX version I'm trying on, maybe this makes a difference?

[SamVerschueren]

Do you maybe press Tab while in the OS menus?

No

Do you maybe have any errors in the console

No

Does this repro when pressing Cmd+] which is an alternative binding for indent lines?

No, can't reproduce with this keybinding which is odd.

---

This is how it always acts like that.

1. Open the project and open that test.txt file
2. Close VS Code entirely
3. Open VS Code which will open test.txt automatically
4. Select all the lines and press Tab

---

My OS X is one patch version higher.

[philipgiuliani]

I also have it on El Capitan 10.11.3

settings.json

{
    "files.trimTrailingWhitespace": true,
    "editor.wrappingIndent": "indent",
    "editor.renderWhitespace": true
}

[sijad]

I also have it, this is my setting.json:

{
  "editor.insertSpaces": true,
  "editor.tabSize": 2,
  "search.exclude": {
    "**/dist": true
  },
  "files.trimTrailingWhitespace": true,
  "files.insertFinalNewline": true,
  "editor.fontFamily": "hack",
  "editor.fontSize": 12,
  "editor.renderWhitespace": true
}

on El Capitan 10.11.3

[alexdima]

Quick update: just updated to El Capitan 10.11.3 and I can now immediately reproduce even with the default settings

[SamVerschueren]

\O/ JEEJ! :)

[egamma]

@philipgiuliani

Can somebody provide a link for VSCode 0.10.6?

Previous releases are available from https://github.com/Microsoft/vscode/wiki/Previous-Releases

[alexdima]

@SamVerschueren @philipgiuliani @nchammas @sijad

Can you please try the following workarounds and let us know if they work.

Possible workaround 1

Edit settings.json to enable auto save with a delay <= 1000:

    "files.autoSave": "afterDelay",
    "files.autoSaveDelay": 1000

Possible workaround 2

Have a "dirty" file permanently open. (i.e. open a new untitled file, make a change in it) and then go about editing other files -- without any need to enable auto save as above.

Explanation

Took a few hours to track down, the problem surfaces so far only on OS X El Capitan 10.11.3 and only on an edit that causes the first file to become "dirty": (i.e. on the edit that brings VS Code from having 0 unsaved files to 1 unsaved file).

The underlying problem is we are updating the OS window to mark the VS Code window as containing a dirty file (icon gets greyed out) synchronously, in a model change listener, while the keydown event is still being handled. This causes e.preventDefault() to malfunction, producing a follow up unexpected input event, while still handling the original keydown event. We then react to the input event and begin applying edits to the model. Thus, the model gets edits applied while it is applying edits, which is unexpected (causing undo to malfunction).

Filed issue against Electron in electron/electron#4438 and we need to revisit all our code paths where we use remote during handling an event.

[nchammas]

@alexandrudima - Workaround 1 works for me. 👍

[joeskeen]

I found another workaround (since I don't like auto-save):

1. insert a space
2. delete the space
3. (don't save)

Now you can tab/shift-tab to your heart's delight. As long as the file is already 'dirty', the bug won't happen.

If you do happen to accidentally clobber your code with tab/shift-tab, you can right-click the file in the Working Files view and select "Revert file".

This is similar to Possible Workaround 2 above, only you don't have to have an extra dirty file open all the time.

[PeterAronZentai]

@alexandrudima thanks! workaround 2 was a real lifesaver. Small addition that the error exists on OS X 10.11.1 as well.

[ElChupacabra26]

I'd also like to add that I'm seeing this behavior in OS X 10.10.5 (Yosemite)

[brunnopleffken]

I'm also experiencing this behavior when pressing SHIFT+TAB.
All the selected block of code is deleted and CMD+Z (undo) doesn't work at all.

OS X El Capitan 10.11.3
VS Code 0.10.8-insider

[philipgiuliani]

@brunnopleffken haha "SHIT + TAB" 😆

[weinand]

@alexandrudima I've verified fix for the insider's build.

[joaomoreno]

@alexandrudima looks great for stable too

[brunnopleffken]

@philipgiuliani Oops! Mistyping an issue may cause situations like this, HAHAHAHA

[yo1dog]

Just want to say thanks for the workarounds and the fixed update today. :)

[ElChupacabra26]

👍 +1 to that

[SamVerschueren]

Thanks @alexandrudima . Appreciate the effort!

[priyank2005]

Thanks for fixing this