Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate to support 0-folder workspaces #34622

Closed
bpasero opened this issue Sep 19, 2017 · 4 comments
Closed

Investigate to support 0-folder workspaces #34622

bpasero opened this issue Sep 19, 2017 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues

Comments

@bpasero
Copy link
Member

bpasero commented Sep 19, 2017

We should see if we could support workspaces with 0 folders.

/cc @sandy081

@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Sep 19, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 19, 2017
@bpasero bpasero assigned bpasero and sandy081 and unassigned sandy081 Sep 19, 2017
@bpasero
Copy link
Member Author

bpasero commented Sep 20, 2017

Our code is quite fit for this, I only found the following that still need multi root adoption (via @dbaeumer work) that currently hardcode workspace.folders[0] usage:

  • processRunnerDetector.ts
  • processTaskSystem.ts
  • task.contribution.ts

Once that is in we should remove the following checks for folders having entries:

  • workspaceMainService#113
  • Configuration#393

And then we can enable the "Remove Folder" action when only one root is there:

  • fileActions.contribution.ts#95

And we need to update the JSON schema.

@sandy081
Copy link
Member

I think we should also update the schema of workspace configuration file to allow no entries for folders

@dbaeumer
Copy link
Member

The places where I use folders[0] is when I am sure that I am in a folder workspace.

@bpasero bpasero added the feature-request Request for new features or functionality label Sep 21, 2017
@bpasero bpasero closed this as completed Sep 21, 2017
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 21, 2017
@bpasero
Copy link
Member Author

bpasero commented Sep 21, 2017

Verification: remove all folders from a workspace configuration file and verify you see no undesired behaviour. The explorer should show up as empty.

@jrieken jrieken added the verified Verification succeeded label Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

4 participants