FTP polish

[isidorn]

• verify file matching did not get broken on case insensitive file systems
• Try to lazily add the FTP folder once ready, since currently the whole explorer is loading on startup
• Fix broken copy ftp folder action -> remote - support copy folder action #41547
• Think about UI to add a new ftp root -> that's extension buisness

from @bpasero

• fileActions seems to miss proper handling of the resource, e.g. not all resources are saveable
• textModelResolverService should this also use the supportsResource check?
• textFileService is probably OK because non-saveable resources will not return as dirty

[jrieken]

editorService will always evaluate to true even if supportResource returns false

@bpasero Unsure, I’d say && binds stronger than || but I might be missing something

textModelResolverService should this also use the supportsResource check?

I kind of does, just the inverse by checking if the scheme is supported from the other side and defaults to the checking with the file service

[bpasero]

Unsure, I’d say && binds stronger than || but I might be missing something

True, my mental compiler does not seem to follow the spec...

[jrieken]

fileActions seems to miss proper handling of the resource, e.g. not all resources are saveable

Shouldn't this be decided by the service? It will throw a ENOPRO error when being called with an unknown scheme and things like the save action should simply handle such errors. I believe that makes things easier as it must handle save failure anyways

[bpasero]

@jrieken yeah that could work. the normal save action seems to just do nothing silently when the resource is not supported (I tried File > Save of a staged resource with git scheme). However, doing "Save As..." results in this:

[jrieken]

Yeah, so the service works as expected and with my latest commit it stops printing the toString-implementation of URI but actually invokes it.

Maybe we are missing well defines error code and a standard file error? I did start to define some for the provider apis: https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L39 and believe a super set of those should be well known to everyone dealing with the file service

[bpasero]

Yeah I am already using similar things for the file service from FileOperationResult. They are more high level than the basic node.js fs ones and I deal with those in most places where I call the file service and if not, they produce a human readable error message at least.

[jrieken]

Closing as we have shelled out most items into separate issues or fixed them.