Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor resize performance for editor with many code lenses #34716

Closed
mjbvz opened this issue Sep 20, 2017 · 2 comments
Closed

Poor resize performance for editor with many code lenses #34716

mjbvz opened this issue Sep 20, 2017 · 2 comments
Assignees
@alexdima
Labels
code-lens perf
Milestone
September 2017

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 20, 2017

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:24:39.530Z) and 1.17.0-insider f7962f0
  • OS Version: Darwin x64 16.7.0
  • Extensions: Extensions are disabled

Steps to Reproduce:

  1. Make sure code lenses are enabled:
"editor.codeLens": true,
"typescript.referencesCodeLens.enabled": true,

  1. Open a file that will have many code lenses, such as this d.ts file
    tsserverlibrary.txt

  2. Try resizing the editor

Bug

sep-20-2017 14-36-16

I don't see any additional calls being made to TS to compute the code lenses.
@vscodebot vscodebot bot added the insiders label Sep 20, 2017
@jrieken jrieken assigned alexdima and unassigned jrieken Sep 21, 2017
@alexdima alexdima added the perf label Sep 21, 2017
@alexdima
Copy link
Member

Nice find!

alexdima added a commit that referenced this issue Sep 21, 2017
@alexdima
Cache content widgets dimensions (#34716)
ad4b098
alexdima added a commit that referenced this issue Sep 21, 2017
@alexdima
Tweaks to content widgets renderings (#34716)
825e63f
This was referenced Sep 21, 2017
Closed
Closed
@alexdima
Copy link
Member

I've optimized as much as feasible in the case of painting these 3000+ code lenses (content widgets).

Most of the time now is taken by the find widget (#34744) and the workbench editor title area (#34745)

@alexdima alexdima added this to the September 2017 milestone Sep 21, 2017
@deysaikat95 deysaikat95 mentioned this issue Sep 25, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
code-lens perf
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@jrieken @alexdima @mjbvz