Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick suggestions not triggered immediately before string/comment #34863

Closed
mjbvz opened this issue Sep 22, 2017 · 0 comments · Fixed by #34864
Closed

Quick suggestions not triggered immediately before string/comment #34863

mjbvz opened this issue Sep 22, 2017 · 0 comments · Fixed by #34864
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
September 2017

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 22, 2017 •
edited
Loading

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:24:39.530Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:

Steps to Reproduce:

1.In a js file:

''
  1. Put the cursor before the quotes '' and type a

Expected
Should trigger quick suggestions

Actual
Does not trigger quick suggestions
@mjbvz mjbvz added the suggest IntelliSense, Auto Complete label Sep 22, 2017
@mjbvz mjbvz self-assigned this Sep 22, 2017
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 22, 2017
@mjbvz
Check type of token that triggered the quick suggestions
2de9465 
Fixes microsoft#34863

**Bug**
Quick suggestions currently check the token at the cursor location to determine if we are in a string or comment. Because token spans are setup like: `[start, end)`, this results in the incorrect token being checked when the quick suggestions are triggered immediatly before a comment or string

**Fix**
Check the token one index back from the cursor
This was referenced Sep 22, 2017
Merged
Closed
@deysaikat95 deysaikat95 mentioned this issue Sep 25, 2017
Closed
@mjbvz mjbvz added this to the October 2017 milestone Sep 25, 2017
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 25, 2017
@mjbvz mjbvz modified the milestones: October 2017, September 2017 Sep 25, 2017
@sandy081 sandy081 added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

Successfully merging a pull request may close this issue.

Check type of token that triggered the quick suggestions mjbvz/vscode
Update from original (#1)
2 participants
@sandy081 @mjbvz