Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Fenced PHP Code Block is Not Syntax Highlighted #3746

Closed
TheColorRed opened this issue Mar 5, 2016 · 5 comments · Fixed by #16502 or #7884
Closed

Markdown Fenced PHP Code Block is Not Syntax Highlighted #3746

TheColorRed opened this issue Mar 5, 2016 · 5 comments · Fixed by #16502 or #7884
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues php PHP support issues verified Verification succeeded
Milestone

Comments

@TheColorRed
Copy link

TheColorRed commented Mar 5, 2016

When creating a code fence, the block doesn't get colored as code (stays white), but it does display as code in the preview.

```php
<?php
//Hello World
echo ('Hello World!');
?>
```

If I tab the code with 4 spaces it does color it properly.

Here is an example:

screenshot from 2016-03-05 16-45-51

@isidorn isidorn added the markdown Markdown support issues label Mar 7, 2016
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Mar 7, 2016
@bpasero bpasero added this to the Backlog milestone Mar 7, 2016
@bpasero
Copy link
Member

bpasero commented Jun 16, 2016

I can still reproduce with our new extension.

@bpasero bpasero assigned kieferrm and unassigned bpasero Jun 16, 2016
@rebornix
Copy link
Member

Firstly we missed the fenced code syntax detecting in markdown tmlanguage, just added it kieferrm/vscode-markdown@bd395e1 .

But we still have problem with plist injecting, which makes the inner code highlighting doesn't work. I'm looking into it right now.

rebornix added a commit to rebornix/vscode that referenced this issue Jun 20, 2016
@kieferrm
Copy link
Member

Adding fenced code for php was necessary but did not fixed the php highlighting issue.

@kieferrm kieferrm reopened this Jun 27, 2016
@Stanzilla
Copy link

Same issue for lua

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 11, 2016

@Stanzilla Lua highlighting seems to work now:

screen shot 2016-11-10 at 6 15 56 pm

Also, the indented code block version is now being correctly not colored:

screen shot 2016-11-10 at 6 17 59 pm

The main bug is still that the fenced php code block is not syntax highlighted. It is unclear what is different about the php language here. The fenced php code block is being detected and parsed properly, but the php grammar does not seem to be applied. Updating bug title to reflect this being specific to php (at least to my knowledge)

@mjbvz mjbvz changed the title Markdown code fence syntax highlighting broken Markdown Fenced PHP Code Block is Not Syntax Highlighted Nov 11, 2016
@mjbvz mjbvz added the php PHP support issues label Nov 11, 2016
@mousetraps mousetraps modified the milestones: November 2016, Backlog Nov 24, 2016
@mousetraps mousetraps assigned mousetraps and unassigned kieferrm and mjbvz Nov 24, 2016
@dbaeumer dbaeumer added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues php PHP support issues verified Verification succeeded
Projects
None yet
10 participants