Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move loaded scripts explorer into VS Code #37767

Closed
weinand opened this issue Nov 7, 2017 · 3 comments
Closed

Move loaded scripts explorer into VS Code #37767

weinand opened this issue Nov 7, 2017 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Nov 7, 2017

Today the "loaded scripts explorer" is implemented in the node-debug extension and is only available for a few JavaScript runtimes despite the fact that the "loaded scripts" functionality is available in the debug adapter protocol.

To make the "loaded scripts explorer" available for all debug extensions, we should move the implementation into the VS Code debugger (and eliminate the QuickPick based variant).

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Nov 7, 2017
@weinand weinand added this to the Backlog milestone Nov 7, 2017
@weinand weinand modified the milestones: Backlog, On Deck Nov 14, 2017
@isidorn isidorn removed their assignment May 11, 2018
@weinand
Copy link
Contributor Author

weinand commented Jul 17, 2018

@isidorn here is a sketch for some initial implementation:

  • debug viewlet shows "LOADED SCRIPTS" view if DA capability supportsLoadedSourcesRequest is on (and if there are in fact loaded scripts).
  • initially read all scripts via the loadedSources request and add them to the tree root as "Source" objects (you don't have to build a tree from them because that code already exists in node-debug and I will try to port it over). Selecting one of them should load the source from the DA.
  • hook up the loadedSource event for add and remove and add (resp. remove) sources from the tree.
  • "LOADED SCRIPTS" should only show if at least one debug session is active.
  • If multiple sessions are active, the "LOADED SCRIPTS" view should show the scripts of the active session.

@weinand weinand modified the milestones: On Deck, July 2018 Jul 17, 2018
isidorn added a commit that referenced this issue Jul 17, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 17, 2018

@weinand I have pushed the initial template for the LOADED SCRIPTS view.
To enable it simply remove this line

The view can be found here and the things you mentioned above should be easily pluggable.

Let me know if I can help in some other way and I can jump on it. Thanks!

@weinand
Copy link
Contributor Author

weinand commented Aug 2, 2018

The implementation is mostly done, but the move will happen in August.

I'll close this one and I've created issue #55650 for August.

@weinand weinand closed this as completed Aug 2, 2018
weinand added a commit that referenced this issue Aug 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants