Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an extension point for customizing gutter interaction. #38568

Closed
changsi-an opened this issue Nov 17, 2017 · 5 comments
Closed

Support an extension point for customizing gutter interaction. #38568

changsi-an opened this issue Nov 17, 2017 · 5 comments
Assignees
Labels
api debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@changsi-an
Copy link

changsi-an commented Nov 17, 2017

  • VSCode Version: 1.18.0
  • OS Version: 16.04.1-Ubuntu

Feature request

It will be useful to be able to control the pop-up menu when user right-clicks the gutter of a document:

screenshot

  • The feature should support adding to / replacing the existing menu items "Add Breakpoint" and "Add Conditional Breakpoint...", potentially based on the current document URI.

  • Then it should be able to control the gutter glyph that would be added after the associated command is executed. It should give the command handler control over what the glyph will look like.

  • After the glyph is added, the context menu will change. There should be a way to control what menu items should display in that menu after the glyph is added.

User Case

This feature is needed, so we can add another type of "breakpoint-like" object to the application's business model. And also disable setting breakpoints when setting a breakpoint scenario does not apply to certain documents.

@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 17, 2017
@weinand weinand added the feature-request Request for new features or functionality label Nov 17, 2017
@weinand weinand added this to the Backlog milestone Nov 17, 2017
@weinand weinand added the api label Nov 17, 2017
@weinand weinand changed the title [Feature request] Support an extension point for customizing gutter interaction. Support an extension point for customizing gutter interaction. Nov 17, 2017
@weinand
Copy link
Contributor

weinand commented Feb 5, 2018

@changsi-an what "breakpoint-like" object do you have in mind?
If we would support to introduce "custom breakpoints" in an extension (with their own icons, state, and custom interaction with the DA), would that help?

@changsi-an
Copy link
Author

changsi-an commented Feb 5, 2018 via email

@weinand
Copy link
Contributor

weinand commented Feb 5, 2018

@changsi-an I think I understand the LogPoints scenario. From your initial description it wasn't clear to me whether you had more advanced "breakpoint-like" things in mind.

@changsi-an
Copy link
Author

changsi-an commented Feb 8, 2018

@weinand Yeah, we don't have a more advanced thing in mind other than LogPoints for now. Potentially more concepts very similar to LogPoints which we have not flatten out yet.

In regard to

we would support to introduce "custom breakpoints" in an extension (with their own icons, state, and custom interaction with the DA), would that help?"

custom interaction with the DA is not quite a concern. I believe we can already do that as long as we grab a DebugSession object. We should then be able to interact with it.

Without actually seeing a draft API, it is hard for me to speculate what you mean by with their own icons, state. I guess your "state"-based approach is a good one. Presumably, we are going to see a "breakpoint-like" object explicitly modeled as a type/Class. Then it has multiple states, with each state associated with a gutter glyph(icon) and a set of menu items, which will be shown when the breakpoint is right-clicked on the gutter. Among them, one state is a "off" state, with no icon and no menu interaction.

@weinand
Copy link
Contributor

weinand commented Sep 12, 2018

Since LogPoints are supported now, no further work planned here.

@weinand weinand closed this as completed Sep 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants