Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore how to support custom breakpoints #42965

Closed
weinand opened this issue Feb 5, 2018 · 2 comments
Closed

Explore how to support custom breakpoints #42965

weinand opened this issue Feb 5, 2018 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Feb 5, 2018

There are a few feature requests around customising breakpoints and their interaction, e.g.:

Opening up all breakpoint functionality for customisation does not seem to be a sustainable approach because it would surface many VS Code implementation details as API.

As an alternative approach we will explore in February how to contribute a new breakpoint type from an extension and how to support it like the existing built-in types.

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 5, 2018
@weinand weinand added this to the February 2018 milestone Feb 5, 2018
@weinand weinand self-assigned this Feb 5, 2018
@weinand
Copy link
Contributor Author

weinand commented Feb 26, 2018

In the February milestone we have explored custom breakpoints based on the example "LogPoints".
The discussion and plan can be found here microsoft/vscode-node-debug2#163

So the first February exploration has been finished but I will keep the item "On Deck" as we continue exploring this after we have implemented LogPoints in March 2018.

@weinand weinand modified the milestones: February 2018, On Deck Feb 26, 2018
@weinand
Copy link
Contributor Author

weinand commented Sep 11, 2018

since LogPoints have been implemented and since rich breakpoint API already exists, we do not intend to work on this.

@weinand weinand closed this as completed Sep 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

1 participant