-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt logging service across the workbench #41680
Labels
Milestone
Comments
joaomoreno
changed the title
Adopt logging service
Adopt logging service across the workbench
Jan 16, 2018
joaomoreno
assigned rebornix, bpasero, jrieken, dbaeumer, Tyriar, RMacfarlane, alexdima, aeschli, chrmarti and isidorn
Jan 26, 2018
Not a fan of doing this overly eager |
Me neither, and I did a pass once already and I think I would not add much more. |
bpasero
added a commit
that referenced
this issue
Feb 5, 2018
@joaomoreno fyi I expanded the |
joaomoreno
added a commit
that referenced
this issue
Feb 20, 2018
I'll close this issue since February is over. Everyone who has unchecked checkboxes, reevaluate whether you want to add logging to your areas and create a separate issue for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
We want to do a quick pass over our code and spread some logging love around. I've decided to split this into into logical parts and assign potential owners to each part. Some of these parts are huge, so take a resonable approach to it:
I suggest to take the following strategy:
info
log level for informational data, which should appear in a regular run of Codetrace
log level for traceable function calls, state changes, etcwarn
log level for non-blocking, non-critical, possibly expected errorsYou can refer to
vs/platform/update/electron-main/abstractUpdateService
for an example.Warning: Be careful with concurrent edits to this issue, as always. Refresh the page before you edit it (hopefully you won't need to) or before you check a checkbox.
Platform
vs/platform/actions
@jriekenvs/platform/backup
@Tyriarvs/platform/broadcast
@bpaserovs/platform/clipboard
@rebornixvs/platform/commands
@jriekenvs/platform/configuration
@sandy081vs/platform/contextkey
@alexandrudimavs/platform/contextview
@joaomorenovs/platform/environment
@joaomorenovs/platform/extensionManagement
@sandy081vs/platform/extensions
@sandy081vs/platform/history
@bpaserovs/platform/instantiation
@jriekenvs/platform/integrity
@alexandrudimavs/platform/issue
@RMacfarlanevs/platform/keybinding
@alexandrudimavs/platform/lifecycle
@bpaserovs/platform/list
@joaomorenovs/platform/markers
@jriekenvs/platform/opener
@jriekenvs/platform/progress
@jriekenvs/platform/request
@joaomorenovs/platform/state
@bpaserovs/platform/storage
@bpaserovs/platform/telemetry
@chrmartivs/platform/theme
@aeschlivs/platform/update
@joaomorenovs/platform/url
@joaomorenovs/platform/windows
@joaomorenovs/platform/workspaces
@bpaseroWorkbench Parts
vs/workbench/parts/backup
@Tyriarvs/workbench/parts/cache
@jriekenvs/workbench/parts/cli
@joaomorenovs/workbench/parts/codeEditor
@alexandrudimavs/workbench/parts/debug
@isidornvs/workbench/parts/emmet
@ramya-rao-avs/workbench/parts/execution
@isidornvs/workbench/parts/extensions
@sandy081vs/workbench/parts/feedback
@RMacfarlanevs/workbench/parts/files
@isidornvs/workbench/parts/html
@mjbvzvs/workbench/parts/markers
@sandy081vs/workbench/parts/output
@sandy081vs/workbench/parts/performance
@jriekenvs/workbench/parts/preferences
@sandy081vs/workbench/parts/quickopen
@bpaserovs/workbench/parts/relauncher
@bpaserovs/workbench/parts/scm
@joaomorenovs/workbench/parts/search
@sandy081vs/workbench/parts/snippets
@jriekenvs/workbench/parts/stats
@chrmartivs/workbench/parts/surveys
@joaomorenovs/workbench/parts/tasks
@dbaeumervs/workbench/parts/terminal
@Tyriarvs/workbench/parts/themes
@aeschlivs/workbench/parts/trust
@joaomorenovs/workbench/parts/update
@joaomorenovs/workbench/parts/watermark
@chrmartivs/workbench/parts/welcome
@chrmartiElectron Main
vs/platform/url/electron-main/urlService
@joaomorenovs/platform/update/electron-main/updateService.*
@joaomorenovs/platform/request/electron-main/requestService
@joaomorenovs/code/electron-main/sharedProcess
@joaomorenovs/code/electron-main/auth
@joaomorenovs/base/parts/ipc/electron-main/ipc.electron-main
@joaomorenoMisc
vs/workbench/api
@jrieken (@joaomoreno: joh, feel free to distribute work if it's too much)vs/editor
@alexandrudima @rebornix (@joaomoreno: not sure if interesting for the editor. we'd have to come up with an editor log service)The text was updated successfully, but these errors were encountered: