Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt logging service across the workbench #41680

Closed
36 of 67 tasks
joaomoreno opened this issue Jan 16, 2018 · 5 comments
Closed
36 of 67 tasks

Adopt logging service across the workbench #41680

joaomoreno opened this issue Jan 16, 2018 · 5 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. plan-item VS Code - planned item for upcoming
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jan 16, 2018

We want to do a quick pass over our code and spread some logging love around. I've decided to split this into into logical parts and assign potential owners to each part. Some of these parts are huge, so take a resonable approach to it:

  • If you don't think it's your responsibility, forward it to the person you think it is;
  • If it's too much work, split it across more people;
  • If it's not relevant to logging, mark it as completed.

I suggest to take the following strategy:

  • Use the info log level for informational data, which should appear in a regular run of Code
  • Use the trace log level for traceable function calls, state changes, etc
  • Use the warn log level for non-blocking, non-critical, possibly expected errors

You can refer to vs/platform/update/electron-main/abstractUpdateService for an example.

Warning: Be careful with concurrent edits to this issue, as always. Refresh the page before you edit it (hopefully you won't need to) or before you check a checkbox.

Platform

Workbench Parts

Electron Main

Misc

@joaomoreno joaomoreno added the plan-item VS Code - planned item for upcoming label Jan 16, 2018
@joaomoreno joaomoreno added this to the January 2018 milestone Jan 16, 2018
@joaomoreno joaomoreno self-assigned this Jan 16, 2018
@joaomoreno joaomoreno changed the title Adopt logging service Adopt logging service across the workbench Jan 16, 2018
@joaomoreno
Copy link
Member Author

@egamma @kieferrm Moving this to February, since we are near endgame.

@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Jan 26, 2018
@isidorn isidorn mentioned this issue Jan 26, 2018
5 tasks
@jrieken jrieken removed their assignment Jan 26, 2018
@jrieken
Copy link
Member

jrieken commented Jan 26, 2018

Not a fan of doing this overly eager

@bpasero
Copy link
Member

bpasero commented Jan 26, 2018

Me neither, and I did a pass once already and I think I would not add much more.

@bpasero
Copy link
Member

bpasero commented Feb 5, 2018

@joaomoreno fyi I expanded the electron-main section and assigned you to some items within.

@bpasero bpasero removed their assignment Feb 5, 2018
@chrmarti chrmarti self-assigned this Feb 5, 2018
@RMacfarlane RMacfarlane removed their assignment Feb 12, 2018
joaomoreno added a commit that referenced this issue Feb 13, 2018
joaomoreno added a commit that referenced this issue Feb 13, 2018
@joaomoreno joaomoreno removed their assignment Feb 20, 2018
joaomoreno added a commit that referenced this issue Feb 20, 2018
joaomoreno added a commit that referenced this issue Feb 20, 2018
joaomoreno added a commit that referenced this issue Feb 20, 2018
related to #41680
@isidorn isidorn removed their assignment Feb 23, 2018
@chrmarti chrmarti removed their assignment Feb 26, 2018
@joaomoreno
Copy link
Member Author

I'll close this issue since February is over. Everyone who has unchecked checkboxes, reevaluate whether you want to add logging to your areas and create a separate issue for that.

@Tyriar Tyriar removed their assignment Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests