"Open in Terminal" is not multiselect-aware

[roblourens]

Testing #41473 on Linux

• Select multiple things in the file explorer
• Right click, "Open in Terminal"
• Only opens one terminal, corresponding to whichever item was actually right clicked

I think it makes sense for multiselect because it's similar to "open containing folder"

[isidorn]

The current behavior is decent.
This feature request might be nice to have. I leave this up to daniel to decide
Code pointer https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/execution/electron-browser/execution.contribution.ts#L87
Just use getResourcesForCommand instead

[Tyriar]

I think the current behavior is fine for me, but if someone has selected multiple items they clearly have intent. Opening this up to PRs

[sriram-dev]

I would like to have a go at this if its fine.

[sriram-dev]

I have a question with respect to implementation. Say two files(or folder) selected are from same folder, should we still open two instances in the terminal ? Or should we check to ensure that same folder isnt duplicated ?

[shobhitchittora]

I can verify that it's not working on MacOS as well. My 2 cents-

1. I think it makes sense to have multiple terminals for multiple item selection.
2. @sriram-dev It makes sense to have multiple terminals for multi-folder selection, but for files within the same <root> folder, it makes sense to have only one terminal with the <root>folder.

Details -

• VSCode Version: 1.20.0-insider (1.20.0-insider) (3f8cf)
• OS Version: High Sierra 10.13.2

[Tyriar]

@sriram-dev by all means 😃

I think only opening a terminal for each once would probably be best personally.

[isidorn]

Fixed via #43552

[bpasero]

Does not work for me:

[isidorn]

This is expected behavior. Only if they have different folder multiple terminals will get opened. Please try with files in different folders. Thanks

[bpasero]

@isidorn I see. Seems to work nicely. I still think if the selection is all from the same root you could just reveal that parent in the terminal. Not doing anything is weird, especially since the action is not disabled.

[isidorn]

Oh I misunderstood your original comment. Yes if they all have the same parent it should open. Pushed a fix now. Thanks